Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 2862543003: Remove CertVerifyProcOpenSSL. (Closed)

Created:
3 years, 7 months ago by davidben
Modified:
3 years, 7 months ago
Reviewers:
Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove CertVerifyProcOpenSSL. This has never been shipped in anything to my knowledge, is unmaintained, unsupported, and I'm not sure it's even still compiled. Remove it before someone tries to use it. (The only non-Android use_openssl_certs port is the NaCl one which does not use these files.) BUG=706445 Review-Url: https://codereview.chromium.org/2862543003 Cr-Commit-Position: refs/heads/master@{#469080} Committed: https://chromium.googlesource.com/chromium/src/+/965721b2c4c2701a64740b0187824ab09b11954e

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -363 lines) Patch
M net/BUILD.gn View 1 3 chunks +2 lines, -12 lines 0 comments Download
M net/cert/cert_verify_proc.cc View 1 3 chunks +1 line, -5 lines 1 comment Download
D net/cert/cert_verify_proc_openssl.h View 1 chunk +0 lines, -35 lines 0 comments Download
D net/cert/cert_verify_proc_openssl.cc View 1 chunk +0 lines, -228 lines 0 comments Download
M net/cert/cert_verify_proc_unittest.cc View 1 4 chunks +1 line, -7 lines 0 comments Download
M net/cert/test_root_certs.h View 1 4 chunks +0 lines, -12 lines 0 comments Download
D net/cert/test_root_certs_openssl.cc View 1 chunk +0 lines, -58 lines 0 comments Download
M net/cert/test_root_certs_unittest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 1 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
davidben
https://codereview.chromium.org/2862543003/diff/20001/net/cert/cert_verify_proc.cc File net/cert/cert_verify_proc.cc (right): https://codereview.chromium.org/2862543003/diff/20001/net/cert/cert_verify_proc.cc#newcode514 net/cert/cert_verify_proc.cc:514: #error Unsupported platform No caller survives this being NULL. ...
3 years, 7 months ago (2017-05-03 18:54:48 UTC) #10
Ryan Sleevi
lgtm
3 years, 7 months ago (2017-05-03 19:27:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2862543003/20001
3 years, 7 months ago (2017-05-03 19:34:18 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:40:45 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/965721b2c4c2701a64740b018782...

Powered by Google App Engine
This is Rietveld 408576698