Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2785)

Side by Side Diff: net/cert/cert_verify_proc.cc

Issue 2862543003: Remove CertVerifyProcOpenSSL. (Closed)
Patch Set: . Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/cert/cert_verify_proc_openssl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_verify_proc.h" 5 #include "net/cert/cert_verify_proc.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 10
(...skipping 15 matching lines...) Expand all
26 #include "net/cert/crl_set.h" 26 #include "net/cert/crl_set.h"
27 #include "net/cert/internal/parse_ocsp.h" 27 #include "net/cert/internal/parse_ocsp.h"
28 #include "net/cert/internal/signature_algorithm.h" 28 #include "net/cert/internal/signature_algorithm.h"
29 #include "net/cert/ocsp_revocation_status.h" 29 #include "net/cert/ocsp_revocation_status.h"
30 #include "net/cert/x509_certificate.h" 30 #include "net/cert/x509_certificate.h"
31 #include "net/der/encode_values.h" 31 #include "net/der/encode_values.h"
32 #include "url/url_canon.h" 32 #include "url/url_canon.h"
33 33
34 #if defined(USE_NSS_CERTS) 34 #if defined(USE_NSS_CERTS)
35 #include "net/cert/cert_verify_proc_nss.h" 35 #include "net/cert/cert_verify_proc_nss.h"
36 #elif defined(USE_OPENSSL_CERTS) && !defined(OS_ANDROID)
37 #include "net/cert/cert_verify_proc_openssl.h"
38 #elif defined(OS_ANDROID) 36 #elif defined(OS_ANDROID)
39 #include "net/cert/cert_verify_proc_android.h" 37 #include "net/cert/cert_verify_proc_android.h"
40 #elif defined(OS_IOS) 38 #elif defined(OS_IOS)
41 #include "net/cert/cert_verify_proc_ios.h" 39 #include "net/cert/cert_verify_proc_ios.h"
42 #elif defined(OS_MACOSX) 40 #elif defined(OS_MACOSX)
43 #include "net/cert/cert_verify_proc_mac.h" 41 #include "net/cert/cert_verify_proc_mac.h"
44 #elif defined(OS_WIN) 42 #elif defined(OS_WIN)
45 #include "base/win/windows_version.h" 43 #include "base/win/windows_version.h"
46 #include "net/cert/cert_verify_proc_win.h" 44 #include "net/cert/cert_verify_proc_win.h"
47 #else 45 #else
(...skipping 449 matching lines...) Expand 10 before | Expand all | Expand 10 after
497 495
498 return true; 496 return true;
499 } 497 }
500 498
501 } // namespace 499 } // namespace
502 500
503 // static 501 // static
504 CertVerifyProc* CertVerifyProc::CreateDefault() { 502 CertVerifyProc* CertVerifyProc::CreateDefault() {
505 #if defined(USE_NSS_CERTS) 503 #if defined(USE_NSS_CERTS)
506 return new CertVerifyProcNSS(); 504 return new CertVerifyProcNSS();
507 #elif defined(USE_OPENSSL_CERTS) && !defined(OS_ANDROID)
508 return new CertVerifyProcOpenSSL();
509 #elif defined(OS_ANDROID) 505 #elif defined(OS_ANDROID)
510 return new CertVerifyProcAndroid(); 506 return new CertVerifyProcAndroid();
511 #elif defined(OS_IOS) 507 #elif defined(OS_IOS)
512 return new CertVerifyProcIOS(); 508 return new CertVerifyProcIOS();
513 #elif defined(OS_MACOSX) 509 #elif defined(OS_MACOSX)
514 return new CertVerifyProcMac(); 510 return new CertVerifyProcMac();
515 #elif defined(OS_WIN) 511 #elif defined(OS_WIN)
516 return new CertVerifyProcWin(); 512 return new CertVerifyProcWin();
517 #else 513 #else
518 return NULL; 514 #error Unsupported platform
davidben 2017/05/03 18:54:48 No caller survives this being NULL. Better to have
519 #endif 515 #endif
520 } 516 }
521 517
522 CertVerifyProc::CertVerifyProc() 518 CertVerifyProc::CertVerifyProc()
523 : sha1_legacy_mode_enabled(base::FeatureList::IsEnabled(kSHA1LegacyMode)) {} 519 : sha1_legacy_mode_enabled(base::FeatureList::IsEnabled(kSHA1LegacyMode)) {}
524 520
525 CertVerifyProc::~CertVerifyProc() {} 521 CertVerifyProc::~CertVerifyProc() {}
526 522
527 int CertVerifyProc::Verify(X509Certificate* cert, 523 int CertVerifyProc::Verify(X509Certificate* cert,
528 const std::string& hostname, 524 const std::string& hostname,
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 return true; 902 return true;
907 903
908 return false; 904 return false;
909 } 905 }
910 906
911 // static 907 // static
912 const base::Feature CertVerifyProc::kSHA1LegacyMode{ 908 const base::Feature CertVerifyProc::kSHA1LegacyMode{
913 "SHA1LegacyMode", base::FEATURE_DISABLED_BY_DEFAULT}; 909 "SHA1LegacyMode", base::FEATURE_DISABLED_BY_DEFAULT};
914 910
915 } // namespace net 911 } // namespace net
OLDNEW
« no previous file with comments | « net/BUILD.gn ('k') | net/cert/cert_verify_proc_openssl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698