Fix bug in virtualized GL context state management upon creation.

Fix bug in virtualized GL context state management upon creation.

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862443002
Cr-Commit-Position: refs/heads/master@{#469007}
Committed: https://chromium.googlesource.com/chromium/src/+/1d44ab0e3d0a7cd05ce1da956bb87a85a8b88174

[Ken Russell (switch to Gerrit), 2017-05-03 00:45:57]

Description was changed from

==========
Fix bug in virtualized GL context state management upon creation.

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
==========

to

==========
Fix bug in virtualized GL context state management upon creation.

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Ken Russell (switch to Gerrit), 2017-05-03 00:48:00]

kbr@chromium.org changed reviewers:
+ jbauman@chromium.org, sunnyps@chromium.org

[Ken Russell (switch to Gerrit), 2017-05-03 00:48:00]

John or Sunny: please review. Thanks.

Others: FYI.

[jbauman, 2017-05-03 00:53:03]

https://codereview.chromium.org/2862443002/diff/1/gpu/ipc/service/gpu_command...
File gpu/ipc/service/gpu_command_buffer_stub.cc (right):

https://codereview.chromium.org/2862443002/diff/1/gpu/ipc/service/gpu_command...
gpu/ipc/service/gpu_command_buffer_stub.cc:843: if
(!context->MakeCurrent(surface_.get())) {
I think this has to go after "initialized_ = true" or else the state restorer
won't do anything.

[jbauman, 2017-05-03 00:58:34]

On 2017/05/03 00:53:03, jbauman wrote:
>
https://codereview.chromium.org/2862443002/diff/1/gpu/ipc/service/gpu_command...
> File gpu/ipc/service/gpu_command_buffer_stub.cc (right):
> 
>
https://codereview.chromium.org/2862443002/diff/1/gpu/ipc/service/gpu_command...
> gpu/ipc/service/gpu_command_buffer_stub.cc:843: if
> (!context->MakeCurrent(surface_.get())) {
> I think this has to go after "initialized_ = true" or else the state restorer
> won't do anything.

looks like I was misreading this. lgtm

[Ken Russell (switch to Gerrit), 2017-05-03 08:06:14]

The CQ bit was checked by kbr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 08:06:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 09:04:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 09:04:01]

Dry run: This issue passed the CQ dry run.

[Ken Russell (switch to Gerrit), 2017-05-03 16:46:35]

The CQ bit was checked by kbr@chromium.org

[commit-bot: I haz the power, 2017-05-03 16:47:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 16:54:11]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493829995464720, "parent_rev":
"1547f4c5289b094a0d0487e6c54297cede4d5db7", "commit_rev":
"1d44ab0e3d0a7cd05ce1da956bb87a85a8b88174"}

[commit-bot: I haz the power, 2017-05-03 16:54:20]

Description was changed from

==========
Fix bug in virtualized GL context state management upon creation.

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Fix bug in virtualized GL context state management upon creation.

Because the first MakeCurrent call against a virtual GL context leaves
the real context state indeterminate (since the GLES2Decoder isn't
initialized and by definition neither is the GLStateRestorer), force
it to be made current again after initialization.

This fixes a longstanding bug where if the next GLES2Decoder to do
significant work was the same one that was just created, it would do
this work with the majority of the real GL context state set to that
of the previous virtual GL context.

BUG=694359
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862443002
Cr-Commit-Position: refs/heads/master@{#469007}
Committed:
https://chromium.googlesource.com/chromium/src/+/1d44ab0e3d0a7cd05ce1da956bb8...
==========

[commit-bot: I haz the power, 2017-05-03 16:54:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1d44ab0e3d0a7cd05ce1da956bb8...

[Zhenyao Mo, 2017-05-03 16:59:11]

On 2017/05/03 16:54:21, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/1d44ab0e3d0a7cd05ce1da956bb8...

Thanks kbr to tracking this down!

[Ken Russell (switch to Gerrit), 2017-05-03 17:47:10]

On 2017/05/03 16:59:11, Zhenyao Mo wrote:
> On 2017/05/03 16:54:21, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/chromium/src/+/1d44ab0e3d0a7cd05ce1da956bb8...
> 
> Thanks kbr to tracking this down!

Thanks Mo! This was a tricky one.