gpu/ipc/service/gpu_command_buffer_stub.h - Issue 2862443002: Fix bug in virtualized GL context state management upon creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/service/gpu_command_buffer_stub.h

Issue 2862443002: Fix bug in virtualized GL context state management upon creation. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gpu/ipc/service/gpu_command_buffer_stub.h

diff --git a/gpu/ipc/service/gpu_command_buffer_stub.h b/gpu/ipc/service/gpu_command_buffer_stub.h

index d65ef938251cb5aca0fa2c83b395a42bd65ba6fa..4264d1a192ed25d1270442b449f0d8cd0f7aedb7 100644

--- a/gpu/ipc/service/gpu_command_buffer_stub.h

+++ b/gpu/ipc/service/gpu_command_buffer_stub.h

@@ -70,6 +70,9 @@ class GPU_EXPORT GpuCommandBufferStub

typedef base::Callback<void(const std::vector<ui::LatencyInfo>&)>

LatencyInfoCallback;

+ // This must leave the GL context associated with the newly-created

+ // GpuCommandBufferStub current, so the GpuChannel can initialize

+ // the gpu::Capabilities.

static std::unique_ptr<GpuCommandBufferStub> Create(

GpuChannel* channel,

GpuCommandBufferStub* share_group,