Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2862303002: Don't lower priority for scripts inserted by doc.write (Closed)

Created:
3 years, 7 months ago by Pat Meenan
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, caseq+blink_chromium.org, Yoav Weiss, loading-reviews_chromium.org, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, fuzzing_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't lower priority for scripts inserted by doc.write HTML Chunks inserted by document.write() are run through a separate instance of the preload scanner from the main document. If the main document scanner has already discovered an image then all scripts discovered by any preload scanner regardless of where they came from would be considered late-body. This behavior causes a regression where a document.write() in the head that includes multiple script tags will discover them but treat them as late-body scripts and only load them one at a time. BUG=713727, 712338 Review-Url: https://codereview.chromium.org/2841363002 Cr-Commit-Position: refs/heads/master@{#467672} (cherry picked from commit 591cbec71ef07912c8c7d2b0acc1efb25196d7f1) Review-Url: https://codereview.chromium.org/2862303002 . Cr-Commit-Position: refs/branch-heads/3071@{#420} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/d255072f8bf07ba7b1058fa6d9a5943d43cbeaef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html View 5 chunks +35 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority-expected.txt View 1 chunk +21 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/docwrite.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 7 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.h View 3 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Pat Meenan
3 years, 7 months ago (2017-05-05 17:42:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d255072f8bf07ba7b1058fa6d9a5943d43cbeaef.

Powered by Google App Engine
This is Rietveld 408576698