Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2841363002: Don't lower priority for scripts inserted by doc.write (Closed)

Created:
3 years, 8 months ago by Pat Meenan
Modified:
3 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, caseq+blink_chromium.org, Yoav Weiss, loading-reviews_chromium.org, blink-reviews-html_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, fuzzing_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, tyoshino+watch_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't lower priority for scripts inserted by doc.write HTML Chunks inserted by document.write() are run through a separate instance of the preload scanner from the main document. If the main document scanner has already discovered an image then all scripts discovered by any preload scanner regardless of where they came from would be considered late-body. This behavior causes a regression where a document.write() in the head that includes multiple script tags will discover them but treat them as late-body scripts and only load them one at a time. reland of http://crbug.com/2826213003 Only change from the original was to fix the layout test. Specifically, the URL for the preload image was not re-used for the actual image which caused the test to issue a console warning about the preload not being used but only if the overall test took long enough for the warning to trigger. Patch set #1 is the original CL untouched BUG=713727, 712338 Review-Url: https://codereview.chromium.org/2826213003 Cr-Commit-Position: refs/heads/master@{#467029} Committed: https://chromium.googlesource.com/chromium/src/+/1e0d3cbbf60c67ba9856eadcb9e829b3c4bec6c7 patch from issue 2826213003 at patchset 70001 (http://crrev.com/2826213003#ps70001) Review-Url: https://codereview.chromium.org/2841363002 Cr-Commit-Position: refs/heads/master@{#467672} Committed: https://chromium.googlesource.com/chromium/src/+/591cbec71ef07912c8c7d2b0acc1efb25196d7f1

Patch Set 1 : Original CL #

Patch Set 2 : Fixed layout test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -66 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority.html View 1 5 chunks +35 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/network/resource-priority-expected.txt View 1 1 chunk +21 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/http/tests/inspector/network/resources/docwrite.js View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/BackgroundHTMLParser.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLDocumentParser.cpp View 5 chunks +15 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.h View 4 chunks +10 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp View 7 chunks +16 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerFuzzer.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp View 1 chunk +7 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.h View 3 chunks +14 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/FetchParameters.cpp View 4 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Pat Meenan
kinuko@ - here is an updated CL that has both the original and changes (sorry ...
3 years, 8 months ago (2017-04-27 01:41:27 UTC) #3
kinuko
lgtm
3 years, 8 months ago (2017-04-27 06:52:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2841363002/20001
3 years, 7 months ago (2017-04-27 12:36:05 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-27 14:41:44 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/591cbec71ef07912c8c7d2b0acc1...

Powered by Google App Engine
This is Rietveld 408576698