VR: Add initial URL bar element and texture.

VR: Add initial URL bar element and texture.

This bar is incomplete, but has most fundamentals present. It needs
proper icons, proper hit testing, and refinements to color and sizing.

BUG=715713
Review-Url: https://codereview.chromium.org/2862283002
Cr-Commit-Position: refs/heads/master@{#470012}
Committed: https://chromium.googlesource.com/chromium/src/+/5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c

[cjgrant, 2017-05-05 16:31:11]

cjgrant@chromium.org changed reviewers:
+ acondor@google.com, mthiesse@chromium.org, tiborg@chromium.org

[cjgrant, 2017-05-05 16:32:23]

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn
File ui/vector_icons/BUILD.gn (right):

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn#ne...
ui/vector_icons/BUILD.gn:11: icons = [
I may split this out, as we need the lock, it comes from elsewhere, and needs
separate approval.

[mthiesse, 2017-05-05 18:45:51]

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn
File ui/vector_icons/BUILD.gn (right):

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn#ne...
ui/vector_icons/BUILD.gn:11: icons = [
On 2017/05/05 16:32:22, cjgrant wrote:
> I may split this out, as we need the lock, it comes from elsewhere, and needs
> separate approval.

It doesn't if you rebase. I reverted my change.

[acondor_, 2017-05-05 19:06:41]

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right):

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/url_bar_texture.cc:21: static constexpr
char kDefaultFontFamily[] = "sans-serif";
In order to avoid this duplicated string, maybe we should add a function to
UiTexture that doesn't provide any text.

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/url_bar_texture.cc:106: //
TODO(cjgrant): Plug in the correct icons based on security level.
Any specific reason for delaying this for later CLs?

[tiborg, 2017-05-05 19:19:25]

On 2017/05/05 19:06:41, acondor wrote:
>
https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
> File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right):
> 
>
https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/textures/url_bar_texture.cc:21: static
constexpr
> char kDefaultFontFamily[] = "sans-serif";
> In order to avoid this duplicated string, maybe we should add a function to
> UiTexture that doesn't provide any text.
> 
>
https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
> chrome/browser/android/vr_shell/textures/url_bar_texture.cc:106: //
> TODO(cjgrant): Plug in the correct icons based on security level.
> Any specific reason for delaying this for later CLs?

lgtm

[cjgrant, 2017-05-08 14:17:41]

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right):

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/url_bar_texture.cc:21: static constexpr
char kDefaultFontFamily[] = "sans-serif";
On 2017/05/05 19:06:41, acondor wrote:
> In order to avoid this duplicated string, maybe we should add a function to
> UiTexture that doesn't provide any text.

Will do.

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/url_bar_texture.cc:106: //
TODO(cjgrant): Plug in the correct icons based on security level.
On 2017/05/05 19:06:41, acondor wrote:
> Any specific reason for delaying this for later CLs?

A few reasons:
- All icons weren't present until I saw Michael's CL. :)
- There's plumbing required to get the security state into this class
- I thought it'd be good to limit the scope of this CL to skia-type work for
easier review

Generally I like more, smaller CLs, but it could go either way.

[cjgrant, 2017-05-08 15:10:24]

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/textures/url_bar_texture.cc (right):

https://codereview.chromium.org/2862283002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/textures/url_bar_texture.cc:21: static constexpr
char kDefaultFontFamily[] = "sans-serif";
On 2017/05/08 14:17:41, cjgrant wrote:
> On 2017/05/05 19:06:41, acondor wrote:
> > In order to avoid this duplicated string, maybe we should add a function to
> > UiTexture that doesn't provide any text.
> 
> Will do.

Done.

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn
File ui/vector_icons/BUILD.gn (right):

https://codereview.chromium.org/2862283002/diff/1/ui/vector_icons/BUILD.gn#ne...
ui/vector_icons/BUILD.gn:11: icons = [
On 2017/05/05 18:45:51, mthiesse wrote:
> On 2017/05/05 16:32:22, cjgrant wrote:
> > I may split this out, as we need the lock, it comes from elsewhere, and
needs
> > separate approval.
> 
> It doesn't if you rebase. I reverted my change.

Done

[acondor_, 2017-05-08 15:28:16]

lgtm

[mthiesse, 2017-05-08 15:29:12]

lgtm

[cjgrant, 2017-05-08 15:30:06]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2017-05-08 15:30:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tiborg@chromium.org
Link to the patchset: https://codereview.chromium.org/2862283002/#ps40001
(title: "Drop anti-aliasing.")

[commit-bot: I haz the power, 2017-05-08 15:30:26]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 16:42:02]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494257406041330,
"parent_rev": "e056f0abedca3d2eb9df5d0ff2659b953c3dfee5", "commit_rev":
"5e8e7d315d4e63e12c823dd7c3fd26a8b8d1995c"}

[commit-bot: I haz the power, 2017-05-08 16:42:10]

Description was changed from

==========
VR: Add initial URL bar element and texture.

This bar is incomplete, but has most fundamentals present. It needs
proper icons, proper hit testing, and refinements to color and sizing.

BUG=715713
==========

to

==========
VR: Add initial URL bar element and texture.

This bar is incomplete, but has most fundamentals present. It needs
proper icons, proper hit testing, and refinements to color and sizing.

BUG=715713

Review-Url: https://codereview.chromium.org/2862283002
Cr-Commit-Position: refs/heads/master@{#470012}
Committed:
https://chromium.googlesource.com/chromium/src/+/5e8e7d315d4e63e12c823dd7c3fd...
==========

[commit-bot: I haz the power, 2017-05-08 16:42:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e8e7d315d4e63e12c823dd7c3fd...