[turbofan] Optimized support for CreateGeneratorObject.

[turbofan] Optimized support for CreateGeneratorObject.

Intrinsic and generic lowering for generator object creation. In a follow-on, create lowering will be addressed.

BUG=v8:6352
Review-Url: https://codereview.chromium.org/2862213002
Cr-Commit-Position: refs/heads/master@{#45171}
Committed: https://chromium.googlesource.com/v8/v8/+/71ee0aa5fc0b39d5d4de389087ffa0e9baeeb33a

[mvstanton, 2017-05-05 09:48:35]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 09:48:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 09:50:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 09:50:30]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/25521)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/40535)

[mvstanton, 2017-05-06 07:17:25]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 07:17:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 07:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 07:44:58]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-05-06 08:05:37]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 08:05:49]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-05-06 08:06:57]

Description was changed from

==========
CreateGeneratorObject - basic TurboFan support.

BUG=v8:6352
==========

to

==========
[turbofan] Optimized support for CreateGeneratorObject.

Intrinsic and generic lowering for generator object creation. In a follow-on,
create lowering will be addressed.

BUG=v8:6352
==========

[mvstanton, 2017-05-06 08:06:58]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2017-05-06 08:07:32]

Hi Benedikt!
Here is the first CL for TurboFan CreateGeneratorObject support. Thanks for the
look...
--Michael

[commit-bot: I haz the power, 2017-05-06 08:38:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 08:38:49]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-05-06 11:50:09]

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
src/compiler/js-operator.cc:911: 2, 1, 0, 1, 1, 0);                             
              // counts
this should have a control input as well.

[mvstanton, 2017-05-06 17:52:30]

thanks for the first look...!

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
src/compiler/js-operator.cc:911: 2, 1, 0, 1, 1, 0);                             
              // counts
On 2017/05/06 11:50:09, Benedikt Meurer wrote:
> this should have a control input as well.

Hmm, I chatted with Michi rather extensively about that, but I guess we focused
on the point that a control *output* isn't necessary. I noticed other
eliminatable opcodes that had neither control in nor out. Can you explain why I
need the control in? (to a newb :p)

[Benedikt Meurer, 2017-05-06 21:29:23]

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
src/compiler/js-operator.cc:911: 2, 1, 0, 1, 1, 0);                             
              // counts
On 2017/05/06 17:52:30, mvstanton wrote:
> On 2017/05/06 11:50:09, Benedikt Meurer wrote:
> > this should have a control input as well.
> 
> Hmm, I chatted with Michi rather extensively about that, but I guess we
focused
> on the point that a control *output* isn't necessary. I noticed other
> eliminatable opcodes that had neither control in nor out. Can you explain why
I
> need the control in? (to a newb :p)

This way the allocation cannot get hoisted above an IfTrue/IfFalse.

[mvstanton, 2017-05-06 22:25:31]

thx again..

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
File src/compiler/js-operator.cc (right):

https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
src/compiler/js-operator.cc:911: 2, 1, 0, 1, 1, 0);                             
              // counts
On 2017/05/06 21:29:23, Benedikt Meurer wrote:
> On 2017/05/06 17:52:30, mvstanton wrote:
> > On 2017/05/06 11:50:09, Benedikt Meurer wrote:
> > > this should have a control input as well.
> > 
> > Hmm, I chatted with Michi rather extensively about that, but I guess we
> focused
> > on the point that a control *output* isn't necessary. I noticed other
> > eliminatable opcodes that had neither control in nor out. Can you explain
why
> I
> > need the control in? (to a newb :p)
> 
> This way the allocation cannot get hoisted above an IfTrue/IfFalse.

Good point. We were thinking about the fact that first other objects are
allocated (a context and various things), and through the wiring into the effect
chain our allocation should end up in the right place. Let's chat about it
Monday...

[Benedikt Meurer, 2017-05-07 04:45:07]

On 2017/05/06 22:25:31, mvstanton wrote:
> thx again..
> 
>
https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
> File src/compiler/js-operator.cc (right):
> 
>
https://codereview.chromium.org/2862213002/diff/30001/src/compiler/js-operato...
> src/compiler/js-operator.cc:911: 2, 1, 0, 1, 1, 0);                           
 
>               // counts
> On 2017/05/06 21:29:23, Benedikt Meurer wrote:
> > On 2017/05/06 17:52:30, mvstanton wrote:
> > > On 2017/05/06 11:50:09, Benedikt Meurer wrote:
> > > > this should have a control input as well.
> > > 
> > > Hmm, I chatted with Michi rather extensively about that, but I guess we
> > focused
> > > on the point that a control *output* isn't necessary. I noticed other
> > > eliminatable opcodes that had neither control in nor out. Can you explain
> why
> > I
> > > need the control in? (to a newb :p)
> > 
> > This way the allocation cannot get hoisted above an IfTrue/IfFalse.
> 
> Good point. We were thinking about the fact that first other objects are
> allocated (a context and various things), and through the wiring into the
effect
> chain our allocation should end up in the right place. Let's chat about it
> Monday...

That might be the case yes, but we explicitly added the control input to
Allocate nodes for this reason and thus all nodes that potentially turn into
Allocate should also have it.

[mvstanton, 2017-05-08 13:22:30]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 13:22:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-05-08 13:31:45]

Control input added.
Thanks,
--Michael

[Benedikt Meurer, 2017-05-08 13:45:27]

lgtm

[commit-bot: I haz the power, 2017-05-08 14:19:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 14:19:26]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-05-08 19:51:19]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2017-05-08 19:51:27]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 19:53:07]

CQ is committing da patch.

Bot data: {"patchset_id": 50001, "attempt_start_ts": 1494273079466040,
"parent_rev": "ededfcd21295904a0e9482f7a8546f09e24fdc6d", "commit_rev":
"71ee0aa5fc0b39d5d4de389087ffa0e9baeeb33a"}

[commit-bot: I haz the power, 2017-05-08 19:53:17]

Description was changed from

==========
[turbofan] Optimized support for CreateGeneratorObject.

Intrinsic and generic lowering for generator object creation. In a follow-on,
create lowering will be addressed.

BUG=v8:6352
==========

to

==========
[turbofan] Optimized support for CreateGeneratorObject.

Intrinsic and generic lowering for generator object creation. In a follow-on,
create lowering will be addressed.

BUG=v8:6352

Review-Url: https://codereview.chromium.org/2862213002
Cr-Commit-Position: refs/heads/master@{#45171}
Committed:
https://chromium.googlesource.com/v8/v8/+/71ee0aa5fc0b39d5d4de389087ffa0e9bae...
==========

[commit-bot: I haz the power, 2017-05-08 19:53:18]

Committed patchset #4 (id:50001) as
https://chromium.googlesource.com/v8/v8/+/71ee0aa5fc0b39d5d4de389087ffa0e9bae...