[turbofan] Create-lowering support for CreateGeneratorObject

[turbofan] Create-lowering support for CreateGeneratorObject

We can inline the allocation of the generator object as long as our
closure is constant.

BUG=v8:6352
Review-Url: https://codereview.chromium.org/2867603002
Cr-Commit-Position: refs/heads/master@{#45200}
Committed: https://chromium.googlesource.com/v8/v8/+/5c66d6fcd44fd2bc206fc1be595adf996ce0a80b

[mvstanton, 2017-05-06 09:45:20]

mvstanton@chromium.org changed reviewers:
+ bmeurer@chromium.org

[mvstanton, 2017-05-06 09:45:21]

Hi Benedikt,
And here is the follow-on that carries out create lowering.
All the best,
--Michael

[mvstanton, 2017-05-06 09:45:27]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-06 09:45:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-06 10:04:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-06 10:05:00]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-05-08 11:40:28]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 11:40:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 11:59:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 11:59:02]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[mvstanton, 2017-05-09 12:02:30]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 12:03:51]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 12:05:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 12:05:43]

Dry run: Try jobs failed on following builders:
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/25656)
  v8_linux_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_verify_csa_rel_ng/...)
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/3...)

[mvstanton, 2017-05-09 12:45:48]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 12:45:55]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 13:17:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 13:17:05]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2017-05-09 13:58:11]

Okay *now* it's done.
Per your offline comment, I'll follow up with Dan and Caitlin on the slack
tracking question.
Thanks,
--Michael

[Benedikt Meurer, 2017-05-09 14:14:40]

LGTM with nit.

https://codereview.chromium.org/2867603002/diff/60001/src/compiler/js-create-...
File src/compiler/js-create-lowering.cc (right):

https://codereview.chromium.org/2867603002/diff/60001/src/compiler/js-create-...
src/compiler/js-create-lowering.cc:563:
closure_type->AsHeapConstant()->Value()->IsJSFunction()) {
This should always be true. Can you DCHECK this instead?

[mvstanton, 2017-05-09 14:21:29]

The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-09 14:21:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mvstanton, 2017-05-09 14:21:34]

The CQ bit was checked by mvstanton@chromium.org

[mvstanton, 2017-05-09 14:21:34]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2867603002/#ps80001
(title: "Nit.")

[commit-bot: I haz the power, 2017-05-09 14:21:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 14:51:34]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1494339694474880,
"parent_rev": "cdbf01ff974dfdd00e18227c466d7f4892e70197", "commit_rev":
"5c66d6fcd44fd2bc206fc1be595adf996ce0a80b"}

[commit-bot: I haz the power, 2017-05-09 14:51:40]

Description was changed from

==========
[turbofan] Create-lowering support for CreateGeneratorObject

We can inline the allocation of the generator object as long as our
closure is constant.

BUG=v8:6352
==========

to

==========
[turbofan] Create-lowering support for CreateGeneratorObject

We can inline the allocation of the generator object as long as our
closure is constant.

BUG=v8:6352

Review-Url: https://codereview.chromium.org/2867603002
Cr-Commit-Position: refs/heads/master@{#45200}
Committed:
https://chromium.googlesource.com/v8/v8/+/5c66d6fcd44fd2bc206fc1be595adf996ce...
==========

[commit-bot: I haz the power, 2017-05-09 14:51:41]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/v8/v8/+/5c66d6fcd44fd2bc206fc1be595adf996ce...