Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2862183002:
[MD settings] test UMA when changing site settings exceptions (Closed)
|
Created:
3 years, 7 months ago by dschuyler Modified:
3 years, 7 months ago Reviewers:
Dan Beam CC:
chromium-reviews, michaelpg+watch-md-settings_chromium.org, dbeam+watch-settings_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] test UMA when changing site settings exceptions
This CL adds unit test for the changes in CL 2861793005.
BUG=718544
Review-Url: https://codereview.chromium.org/2862183002
Cr-Commit-Position: refs/heads/master@{#469794}
Committed: https://chromium.googlesource.com/chromium/src/+/238a3acf12b53686a2b043ef0b296a5bf7d32845
Patch Set 1 #
Total comments: 4
Patch Set 2 : review changs #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + dbeam@chromium.org
lgtm https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc (right): https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:257: base::ListValue setArgs; nit maybe for a followup: all of the args things should be cpp_vars_like_this (notLikeThis). https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:288: histograms.ExpectTotalCount(kUmaBase, 2); // Including the "block" above. nit: you could just make a new scope { base::HistogramTester histograms; histograms.ExpectTotalCount(...); } ... { base::HistogramTester histograms; histograms.ExpectTotalCount(...); }
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... File chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc (right): https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:257: base::ListValue setArgs; On 2017/05/05 01:40:48, Dan Beam wrote: > nit maybe for a followup: all of the args things should be cpp_vars_like_this > (notLikeThis). Done. https://codereview.chromium.org/2862183002/diff/1/chrome/browser/ui/webui/set... chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc:288: histograms.ExpectTotalCount(kUmaBase, 2); // Including the "block" above. On 2017/05/05 01:40:48, Dan Beam wrote: > nit: you could just make a new scope > > { > base::HistogramTester histograms; > histograms.ExpectTotalCount(...); > } > > ... > > { > base::HistogramTester histograms; > histograms.ExpectTotalCount(...); > } Done.
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org Link to the patchset: https://codereview.chromium.org/2862183002/#ps20001 (title: "review changs")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494025655167750,
"parent_rev": "175c5da545b7eb584f4916cc19f888685c40d0eb", "commit_rev":
"238a3acf12b53686a2b043ef0b296a5bf7d32845"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] test UMA when changing site settings exceptions This CL adds unit test for the changes in CL 2861793005. BUG=718544 ========== to ========== [MD settings] test UMA when changing site settings exceptions This CL adds unit test for the changes in CL 2861793005. BUG=718544 Review-Url: https://codereview.chromium.org/2862183002 Cr-Commit-Position: refs/heads/master@{#469794} Committed: https://chromium.googlesource.com/chromium/src/+/238a3acf12b53686a2b043ef0b29... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/238a3acf12b53686a2b043ef0b29... |
