[MD settings] test UMA when changing site settings exceptions

chrome/browser/ui/webui/settings/site_settings_handler_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/settings/site_settings_handler.h"
 
 #include <memory>
 
+#include "base/test/histogram_tester.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/ui/webui/site_settings_helper.h"
 #include "chrome/test/base/testing_profile.h"
 #include "components/content_settings/core/common/content_settings.h"
 #include "components/content_settings/core/common/content_settings_types.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "content/public/test/test_web_ui.h"
 #include "extensions/common/extension_builder.h"
@@ skipping 227 matching lines @@
   EXPECT_EQ(2U, web_ui()->call_data().size());
 
   // Verify that the default has been set to 'Blocked'.
   handler()->HandleGetDefaultValueForContentType(&getArgs);
   ValidateDefault("block", "default", 3U);
 }
 
 TEST_F(SiteSettingsHandlerTest, Origins) {
   // Test the JS -> C++ -> JS callback path for configuring origins, by setting
   // Google.com to blocked.
   base::ListValue setArgs;

[Dan Beam, 2017/05/05 01:40:48]

nit maybe for a followup: all of the args things should be cpp_vars_like_this
(notLikeThis).

[dschuyler, 2017/05/05 21:21:35]

Done.

   std::string google("http://www.google.com");
   setArgs.AppendString(google);  // Primary pattern.
   setArgs.AppendString(google);  // Secondary pattern.
   setArgs.AppendString("notifications");
   setArgs.AppendString("block");
   setArgs.AppendBoolean(false);  // Incognito.
+  base::HistogramTester histograms;
   handler()->HandleSetCategoryPermissionForOrigin(&setArgs);
   EXPECT_EQ(1U, web_ui()->call_data().size());
+  const std::string kUmaBase("WebsiteSettings.Menu.PermissionChanged");
+  histograms.ExpectTotalCount(kUmaBase, 1);
+  histograms.ExpectTotalCount(kUmaBase + ".Allowed", 0);
+  histograms.ExpectTotalCount(kUmaBase + ".Blocked", 1);
+  histograms.ExpectTotalCount(kUmaBase + ".Reset", 0);
 
   // Verify the change was successful.
   base::ListValue listArgs;
   listArgs.AppendString(kCallbackId);
   listArgs.AppendString("notifications");
   handler()->HandleGetExceptionList(&listArgs);
   ValidateOrigin(google, google, google, "block", "preference", 2U);
 
   // Reset things back to how they were.
   base::ListValue resetArgs;
   resetArgs.AppendString(google);
   resetArgs.AppendString(google);
   resetArgs.AppendString("notifications");
   resetArgs.AppendBoolean(false);  // Incognito.
   handler()->HandleResetCategoryPermissionForOrigin(&resetArgs);
   EXPECT_EQ(3U, web_ui()->call_data().size());
+  histograms.ExpectTotalCount(kUmaBase, 2);  // Including the "block" above.

[Dan Beam, 2017/05/05 01:40:48]

nit: you could just make a new scope

{
  base::HistogramTester histograms;
  histograms.ExpectTotalCount(...);
}

...

{
  base::HistogramTester histograms;
  histograms.ExpectTotalCount(...);
}

[dschuyler, 2017/05/05 21:21:35]

Done.

+  histograms.ExpectTotalCount(kUmaBase + ".Allowed", 0);
+  histograms.ExpectTotalCount(kUmaBase + ".Blocked", 1);
+  histograms.ExpectTotalCount(kUmaBase + ".Reset", 1);
 
   // Verify the reset was successful.
   handler()->HandleGetExceptionList(&listArgs);
   ValidateNoOrigin(4U);
 }
 
 TEST_F(SiteSettingsHandlerTest, ExceptionHelpers) {
   ContentSettingsPattern pattern =
       ContentSettingsPattern::FromString("[*.]google.com");
   std::unique_ptr<base::DictionaryValue> exception =
@@ skipping 102 matching lines @@
   args.AppendString("http://www.google.com");
   handler()->HandleRemoveZoomLevel(&args);
   ValidateZoom("", "", 3U);
 
   double default_level = host_zoom_map->GetDefaultZoomLevel();
   double level = host_zoom_map->GetZoomLevelForHostAndScheme("http", host);
   EXPECT_EQ(default_level, level);
 }
 
 }  // namespace settings