Issue 286193004: ARM64 simulator fix for EXTR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 286193004: ARM64 simulator fix for EXTR (Closed)

Created:
6 years, 7 months ago by Fritz

Modified:
6 years, 6 months ago

Reviewers:
Sven Panne, Rodolph Perfetta (ARM), jbramley

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

ARM64 simulator fix for EXTR Fixes extract when imms = 0 because a left shift of 64 is not valid.

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -18 lines)			Patch
	M	src/arm64/simulator-arm64.cc	View		1 chunk	+6 lines, -4 lines	0 comments	Download
	M	test/cctest/test-assembler-arm64.cc	View		1 chunk	+18 lines, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

LGTM from my side, but let's wait for some feedback from one of the ARM ...

6 years, 7 months ago (2014-05-16 10:47:04 UTC) #2

Rodolph Perfetta

On 2014/05/20 19:45:03, Fritz wrote: > Do I need to do anything else to land ...

6 years, 7 months ago (2014-05-20 19:53:07 UTC) #5

Rodolph Perfetta (ARM)

6 years, 7 months ago (2014-05-23 09:47:53 UTC) #6

On 2014/05/20 19:53:07, Rodolph Perfetta wrote:
> On 2014/05/20 19:45:03, Fritz wrote:
> > Do I need to do anything else to land this?
> 
> I don't think so :-)

Committed, you can close your review.

Expand Messages | Collapse Messages