Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 2861653004: [Mac] Adjust the size, position and color of security indicator divider. (Closed)

Created:
3 years, 7 months ago by shrike
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Adjust the size, position and color of security indicator divider. The divider's height, position, and color were all slightly off-spec. R=avi@chromium.org BUG=677142 Review-Url: https://codereview.chromium.org/2861653004 Cr-Commit-Position: refs/heads/master@{#469761} Committed: https://chromium.googlesource.com/chromium/src/+/c56faf1fbb17173715d43a6d975933f8dac4f1a9

Patch Set 1 #

Patch Set 2 : Final tweaks. #

Patch Set 3 : Adjustments for non-Retina. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -15 lines) Patch
M chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm View 1 2 2 chunks +24 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
shrike
PTAL
3 years, 7 months ago (2017-05-04 23:29:23 UTC) #1
Avi (use Gerrit)
lgtm Looks reasonable.
3 years, 7 months ago (2017-05-04 23:31:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861653004/40001
3 years, 7 months ago (2017-05-05 19:22:03 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 19:57:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c56faf1fbb17173715d43a6d9759...

Powered by Google App Engine
This is Rietveld 408576698