Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Unified Diff: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm

Issue 2861653004: [Mac] Adjust the size, position and color of security indicator divider. (Closed)
Patch Set: Adjustments for non-Retina. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
diff --git a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
index 58c2e230bb9619d713613fc316d4170c0ad9e4b5..a2ad4effcfd93fcd85b962bd3b500f5609c0c9b9 100644
--- a/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
+++ b/chrome/browser/ui/cocoa/location_bar/location_bar_decoration.mm
@@ -16,10 +16,9 @@
namespace {
-// Color values for the bubble decoration divider.
-const CGFloat kDividerAlpha = 38.0;
-const CGFloat kDividerGrayScale = 0.0;
-const CGFloat kDividerIncognitoGrayScale = 1.0;
+// Gray values for the bubble decoration divider.
+const CGFloat kDividerGray = 0xFFA6A6A6;
+const CGFloat kDividerGrayIncognito = 0xFFDFDFDF;
// Color values for the hover and pressed background.
const SkColor kHoverBackgroundColor = 0x14000000;
@@ -409,10 +408,10 @@ SkColor LocationBarDecoration::GetMaterialIconColor(
NSColor* LocationBarDecoration::GetDividerColor(
bool location_bar_is_dark) const {
- CGFloat gray_scale =
- location_bar_is_dark ? kDividerIncognitoGrayScale : kDividerGrayScale;
- return
- [NSColor colorWithCalibratedWhite:gray_scale alpha:kDividerAlpha / 255.0];
+ if (location_bar_is_dark) {
+ return skia::SkColorToSRGBNSColor(kDividerGrayIncognito);
+ }
+ return skia::SkColorToSRGBNSColor(kDividerGray);
}
const gfx::VectorIcon* LocationBarDecoration::GetMaterialVectorIcon() const {
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/location_bar/security_state_bubble_decoration.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698