Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2861583007: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)

Created:
3 years, 7 months ago by dewittj
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the snapshot controller Changes include: -- moving all timing parameters (how long to wait before snapshotting) to the snapshot controller -- introducing 2 new factory methods for obtaining a snapshot controller -- more explicit ownership and transfer of the snapshot controller BUG=712473 Review-Url: https://codereview.chromium.org/2822023002 Cr-Commit-Position: refs/heads/master@{#468765} (cherry picked from commit 5e17a9358f03488e71cba7c4b6786afba95fed6e) Review-Url: https://codereview.chromium.org/2861583007 . Cr-Commit-Position: refs/branch-heads/3071@{#382} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/b7ff7afba5f6d89f8a9b29dd12c4a7d5d15fa655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -54 lines) Patch
M chrome/browser/android/offline_pages/background_loader_offliner.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner.cc View 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/android/offline_pages/background_loader_offliner_unittest.cc View 2 chunks +9 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/prerendering_loader.cc View 3 chunks +6 lines, -22 lines 0 comments Download
M chrome/browser/android/offline_pages/recent_tab_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/offline_pages/core/snapshot_controller.h View 2 chunks +12 lines, -2 lines 0 comments Download
M components/offline_pages/core/snapshot_controller.cc View 4 chunks +38 lines, -15 lines 0 comments Download
M components/offline_pages/core/snapshot_controller_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
dewittj
3 years, 7 months ago (2017-05-03 20:42:24 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7ff7afba5f6d89f8a9b29dd12c4a7d5d15fa655.

Powered by Google App Engine
This is Rietveld 408576698