Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5683)

Unified Diff: chrome/browser/android/offline_pages/background_loader_offliner.cc

Issue 2861583007: [Offline pages]: Move logic for whether to consider the DocumentAvailableInMainFrame signal to the … (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/background_loader_offliner.cc
diff --git a/chrome/browser/android/offline_pages/background_loader_offliner.cc b/chrome/browser/android/offline_pages/background_loader_offliner.cc
index f8f86b6e0a7fc35b9447a46b67f0a3616eb470fc..5e18f9ff775e7b475516983c5c80758c501e1a8c 100644
--- a/chrome/browser/android/offline_pages/background_loader_offliner.cc
+++ b/chrome/browser/android/offline_pages/background_loader_offliner.cc
@@ -21,8 +21,6 @@
namespace offline_pages {
namespace {
-const long kOfflinePageDelayMs = 2000;
-const long kOfflineDomContentLoadedMs = 25000;
class OfflinerData : public content::WebContentsUserData<OfflinerData> {
public:
@@ -74,7 +72,6 @@ BackgroundLoaderOffliner::BackgroundLoaderOffliner(
is_low_end_device_(base::SysInfo::IsLowEndDevice()),
save_state_(NONE),
page_load_state_(SUCCESS),
- page_delay_ms_(kOfflinePageDelayMs),
network_bytes_(0LL),
weak_ptr_factory_(this) {
DCHECK(offline_page_model_);
@@ -168,9 +165,8 @@ bool BackgroundLoaderOffliner::LoadAndSave(
// Load page attempt.
loader_.get()->LoadPage(request.url());
- snapshot_controller_.reset(
- new SnapshotController(base::ThreadTaskRunnerHandle::Get(), this,
- kOfflineDomContentLoadedMs, page_delay_ms_));
+ snapshot_controller_ = SnapshotController::CreateForBackgroundOfflining(
+ base::ThreadTaskRunnerHandle::Get(), this);
return true;
}
@@ -261,8 +257,9 @@ void BackgroundLoaderOffliner::DidFinishNavigation(
}
}
-void BackgroundLoaderOffliner::SetPageDelayForTest(long delay_ms) {
- page_delay_ms_ = delay_ms;
+void BackgroundLoaderOffliner::SetSnapshotControllerForTest(
+ std::unique_ptr<SnapshotController> controller) {
+ snapshot_controller_ = std::move(controller);
}
void BackgroundLoaderOffliner::OnNetworkBytesChanged(int64_t bytes) {

Powered by Google App Engine
This is Rietveld 408576698