Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2861583004: Remove the QuicChromiumClientStream::Delegate::HasSendHeadersComplete() (Closed)

Created:
3 years, 7 months ago by Ryan Hamilton
Modified:
3 years, 7 months ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the QuicChromiumClientStream::Delegate::HasSendHeadersComplete() method and instead explicitly track the state in QuicChromiumClientStream. BUG=716563 Review-Url: https://codereview.chromium.org/2861583004 Cr-Commit-Position: refs/heads/master@{#469221} Committed: https://chromium.googlesource.com/chromium/src/+/d4651b91b5bfdeb747f0f17a53e43958f4f399f3

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -26 lines) Patch
M net/quic/chromium/bidirectional_stream_quic_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/bidirectional_stream_quic_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session_test.cc View 1 2 chunks +5 lines, -7 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_stream.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_http_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/chromium/quic_http_stream.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Ryan Hamilton
3 years, 7 months ago (2017-05-03 04:17:18 UTC) #3
Zhongyi Shi
lgtm
3 years, 7 months ago (2017-05-03 23:09:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861583004/20001
3 years, 7 months ago (2017-05-03 23:11:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/170256) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, ...
3 years, 7 months ago (2017-05-03 23:15:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861583004/40001
3 years, 7 months ago (2017-05-03 23:35:04 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-04 00:41:32 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d4651b91b5bfdeb747f0f17a53e4...

Powered by Google App Engine
This is Rietveld 408576698