Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: net/quic/chromium/quic_chromium_client_session_test.cc

Issue 2861583004: Remove the QuicChromiumClientStream::Delegate::HasSendHeadersComplete() (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/chromium/quic_chromium_client_session_test.cc
diff --git a/net/quic/chromium/quic_chromium_client_session_test.cc b/net/quic/chromium/quic_chromium_client_session_test.cc
index 2ac521305b457e265ea593dcd845e8d1fbf41ac8..2242250837c9f5290a999a250bd8be39a88986bf 100644
--- a/net/quic/chromium/quic_chromium_client_session_test.cc
+++ b/net/quic/chromium/quic_chromium_client_session_test.cc
@@ -73,7 +73,6 @@ class MockStreamDelegate : public QuicChromiumClientStream::Delegate {
MOCK_METHOD0(OnDataAvailable, void());
MOCK_METHOD0(OnClose, void());
MOCK_METHOD1(OnError, void(int));
- MOCK_METHOD0(HasSendHeadersComplete, bool());
private:
DISALLOW_COPY_AND_ASSIGN(MockStreamDelegate);
@@ -761,18 +760,17 @@ TEST_P(QuicChromiumClientSessionTest, Priority) {
Initialize();
CompleteCryptoHandshake();
+
for (SpdyPriority priority : {kV3HighestPriority, kV3LowestPriority}) {
QuicChromiumClientStream* stream =
session_->CreateOutgoingDynamicStream(priority);
EXPECT_EQ(kV3HighestPriority, stream->priority());
- MockStreamDelegate delegate;
- EXPECT_CALL(delegate, HasSendHeadersComplete())
- .WillOnce(testing::Return(true));
- stream->SetDelegate(&delegate);
+ SpdyHeaderBlock headers;
+ stream->WriteHeaders(std::move(headers), /*fin*/ true,
+ /*ack_listener*/ nullptr);
+
EXPECT_EQ(priority, stream->priority());
- stream->SetDelegate(nullptr);
- session_->CloseStream(stream->id());
}
}
« no previous file with comments | « net/quic/chromium/bidirectional_stream_quic_impl.cc ('k') | net/quic/chromium/quic_chromium_client_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698