Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 2861543002: [MD settings] omit embeddingOrigin for site exceptions (Closed)

Created:
3 years, 7 months ago by dschuyler
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG=714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848933003 Cr-Commit-Position: refs/heads/master@{#468199} (cherry picked from commit 8638bd4941bbccbfa49ece2ca400807b067cd6ae) Review-Url: https://codereview.chromium.org/2861543002 . Cr-Commit-Position: refs/branch-heads/3071@{#364} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/af11c8deb15330c1ad081e414de37cd740b3918b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M chrome/browser/resources/settings/site_settings/site_settings_prefs_browser_proxy.js View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dschuyler
3 years, 7 months ago (2017-05-02 22:56:52 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
af11c8deb15330c1ad081e414de37cd740b3918b.

Powered by Google App Engine
This is Rietveld 408576698