Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2848933003:
[MD settings] omit embeddingOrigin for site exceptions (Closed)
|
Created:
3 years, 7 months ago by dschuyler Modified:
3 years, 7 months ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
Description[MD settings] omit embeddingOrigin for site exceptions
This CL changes how the embeddingOrigin is set on content exceptions.
This is now more like it was done in the old options, where the
embedding origin was not sent from JavaScript.
BUG=714584
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2848933003
Cr-Commit-Position: refs/heads/master@{#468199}
Committed: https://chromium.googlesource.com/chromium/src/+/8638bd4941bbccbfa49ece2ca400807b067cd6ae
Patch Set 1 #Patch Set 2 : reduced changed files #Messages
Total messages: 21 (15 generated)
Description was changed from ========== [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG=714584 ========== to ========== [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG=714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dschuyler@chromium.org changed reviewers: + dpapad@chromium.org
LGTM
The CQ bit was checked by dschuyler@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/04/28 23:47:35, dpapad wrote: > LGTM I found that the old options *only* sends the embedding origin on delete of the item; it is *not* sent on removing for editing. I think we match that behavior. PTAL
Patchset #3 (id:40001) has been deleted
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
On 2017/04/29 00:31:00, dschuyler wrote: > On 2017/04/28 23:47:35, dpapad wrote: > > LGTM > > I found that the old options *only* sends the embedding origin on delete of the > item; it is *not* sent on removing for editing. > I think we match that behavior. > > PTAL Please ignore comment #11 (the patch for that note has been deleted).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by dschuyler@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493427193801330,
"parent_rev": "b416391e0ae62217afb7ea5ffeb04ab2640a96ed", "commit_rev":
"8638bd4941bbccbfa49ece2ca400807b067cd6ae"}
Message was sent while issue was closed.
Description was changed from ========== [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG=714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== [MD settings] omit embeddingOrigin for site exceptions This CL changes how the embeddingOrigin is set on content exceptions. This is now more like it was done in the old options, where the embedding origin was not sent from JavaScript. BUG=714584 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2848933003 Cr-Commit-Position: refs/heads/master@{#468199} Committed: https://chromium.googlesource.com/chromium/src/+/8638bd4941bbccbfa49ece2ca400... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8638bd4941bbccbfa49ece2ca400... |
