chrome/browser/resources/settings/basic_page/basic_page.html - Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/basic_page/basic_page.html

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/settings/basic_page/basic_page.html

diff --git a/chrome/browser/resources/settings/basic_page/basic_page.html b/chrome/browser/resources/settings/basic_page/basic_page.html

index 5e3cdc0dd533f6b5884c69d35759e34b178455c8..7542c5940d3e17cc39dd01c08144852d68914dcf 100644

--- a/chrome/browser/resources/settings/basic_page/basic_page.html

+++ b/chrome/browser/resources/settings/basic_page/basic_page.html

@@ -125,7 +125,8 @@

<settings-section page-title="$i18n{appearancePageTitle}"

section="appearance">

<settings-appearance-page prefs="{{prefs}}"

- page-visibility="[[getPageVisibility_('appearance')]]">

+ page-visibility="[[getPageVisibility_(pageVisibility,

dpapad 2017/05/03 23:02:25 IIUC, only the changes in this file are necessary

stevenjb 2017/05/03 23:31:43 Theoretically yes, but I really don't want to aban

+ 'appearance')]]">

</settings-appearance-page>

</settings-section>

</template>

@@ -207,7 +208,8 @@

<settings-section page-title="$i18n{privacyPageTitle}"

section="privacy">

<settings-privacy-page prefs="{{prefs}}"

- page-visibility="[[getPageVisibility_('privacy')]]">

+ page-visibility="[[getPageVisibility_(pageVisibility,

+ 'privacy')]]">

</settings-privacy-page>

</settings-section>

</template>

@@ -233,7 +235,8 @@

<settings-section page-title="$i18n{downloadsPageTitle}"

section="downloads">

<settings-downloads-page prefs="{{prefs}}"

- page-visibility="[[getPageVisibility_('downloads')]]">

+ page-visibility="[[getPageVisibility_(pageVisibility,

+ 'downloads')]]">

</settings-downloads-page>

</settings-section>

</template>