MD Settings: Fix subpage visibility and add appearance page tests

chrome/browser/resources/settings/basic_page/basic_page.html

 <link rel="import" href="chrome://resources/html/polymer.html">
 <link rel="import" href="chrome://resources/cr_elements/hidden_style_css.html">
 <link rel="import" href="../appearance_page/appearance_page.html">
 <link rel="import" href="../controls/settings_idle_load.html">
 <link rel="import" href="../on_startup_page/on_startup_page.html">
 <link rel="import" href="../people_page/people_page.html">
 <link rel="import" href="../reset_page/reset_profile_banner.html">
 <link rel="import" href="../search_page/search_page.html">
 <link rel="import" href="../settings_page/main_page_behavior.html">
 <link rel="import" href="../settings_page/settings_section.html">
@@ skipping 107 matching lines @@
           <settings-section page-title="$i18n{peoplePageTitle}"
               section="people">
             <settings-people-page prefs="{{prefs}}"></settings-people-page>
           </settings-section>
         </template>
         <template is="dom-if" if="[[showPage_(pageVisibility.appearance)]]"
             restamp>
           <settings-section page-title="$i18n{appearancePageTitle}"
               section="appearance">
             <settings-appearance-page prefs="{{prefs}}"
-                page-visibility="[[getPageVisibility_('appearance')]]">
+                page-visibility="[[getPageVisibility_(pageVisibility,

[dpapad, 2017/05/03 23:02:25]

IIUC, only the changes in this file are necessary to fix the regression (missing
sections). All other changes (except for the tests), can be reverted, no?

[stevenjb, 2017/05/03 23:31:43]

Theoretically yes, but I really don't want to abandon those changes.

+                    'appearance')]]">
             </settings-appearance-page>
           </settings-section>
         </template>
 <if expr="chromeos">
         <template is="dom-if" if="[[showPage_(pageVisibility.device)]]" restamp>
           <settings-section page-title="$i18n{devicePageTitle}"
               section="device">
             <settings-device-page prefs="{{prefs}}"></settings-device-page>
           </settings-section>
         </template>
@@ skipping 61 matching lines @@
                   page-visibility="[[pageVisibility.dateTime]]">
               </settings-date-time-page>
             </settings-section>
           </template>
 </if>
           <template is="dom-if" if="[[showPage_(pageVisibility.privacy)]]"
               restamp>
             <settings-section page-title="$i18n{privacyPageTitle}"
                 section="privacy">
               <settings-privacy-page prefs="{{prefs}}"
-                  page-visibility="[[getPageVisibility_('privacy')]]">
+                  page-visibility="[[getPageVisibility_(pageVisibility,
+                      'privacy')]]">
               </settings-privacy-page>
             </settings-section>
           </template>
           <template is="dom-if"
               if="[[showPage_(pageVisibility.passwordsAndForms)]]" restamp>
             <settings-section
                 page-title="$i18n{passwordsAndAutofillPageTitle}"
                 section="passwordsAndForms">
               <settings-passwords-and-forms-page prefs="{{prefs}}">
               </settings-passwords-and-forms-page>
             </settings-section>
           </template>
           <template is="dom-if" if="[[showPage_(pageVisibility.languages)]]"
               restamp>
             <settings-section page-title="$i18n{languagesPageTitle}"
                 section="languages">
               <settings-languages-page prefs="{{prefs}}">
               </settings-languages-page>
             </settings-section>
           </template>
           <template is="dom-if" if="[[showPage_(pageVisibility.downloads)]]"
               restamp>
             <settings-section page-title="$i18n{downloadsPageTitle}"
                 section="downloads">
               <settings-downloads-page prefs="{{prefs}}"
-                  page-visibility="[[getPageVisibility_('downloads')]]">
+                  page-visibility="[[getPageVisibility_(pageVisibility,
+                      'downloads')]]">
               </settings-downloads-page>
             </settings-section>
           </template>
           <template is="dom-if" if="[[showPage_(pageVisibility.printing)]]"
               restamp>
             <settings-section page-title="$i18n{printingPageTitle}"
                 section="printing">
               <settings-printing-page prefs="{{prefs}}">
               </settings-printing-page>
             </settings-section>
@@ skipping 18 matching lines @@
                 section="reset">
               <settings-reset-page></settings-reset-page>
             </settings-section>
           </template>
         </div>
       </template>
     </template>
   </template>
   <script src="basic_page.js"></script>
 </dom-module>