Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/appearance_page/appearance_page.js
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.js b/chrome/browser/resources/settings/appearance_page/appearance_page.js
index 289e20bdbd4ebc0240bbd7e127c20579ecd8e3af..d5a95cd54a314a1853a62c1f25321f7d86eff51e 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.js
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.js
@@ -144,6 +144,15 @@ Polymer({
},
/**
+ * @param {boolean|undefined} visibility
+ * @return {boolean}
+ * @private
+ */
+ showPage_: function(visibility) {
+ return visibility !== false;
+ },
+
+ /**
* @param {number} zoom
* @return {number} A zoom easier read by users.
* @private
@@ -294,15 +303,6 @@ Polymer({
},
/**
- * @param {boolean} bookmarksBarVisible if bookmarks bar option is visible.
- * @return {string} 'first' if the argument is false or empty otherwise.
- * @private
- */
- getFirst_: function(bookmarksBarVisible) {
- return !bookmarksBarVisible ? 'first' : '';
- },
-
- /**
* @see content::ZoomValuesEqual().
* @param {number} zoom1
* @param {number} zoom2

Powered by Google App Engine
This is Rietveld 408576698