Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7170)

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/privacy_page/privacy_page.js
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js
index c9a025b3a5eab8e93e2dc65d7e1afd4c307fe8c8..174bdcdbf2be815c94d56e3b022d65206c57155b 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js
@@ -42,7 +42,12 @@ Polymer({
* Dictionary defining page visibility.
* @type {!PrivacyPageVisibility}
*/
- pageVisibility: Object,
+ pageVisibility: {
+ type: Object,
+ value: function() {
+ return {};
+ },
+ },
/** @private */
isGuest_: {
@@ -150,6 +155,15 @@ Polymer({
},
/**
+ * @param {boolean|undefined} visibility
+ * @return {boolean}
+ * @private
+ */
+ showPage_: function(visibility) {
+ return visibility !== false;
+ },
+
+ /**
* @param {Event} event
* @private
*/

Powered by Google App Engine
This is Rietveld 408576698