chrome/browser/resources/settings/privacy_page/privacy_page.html - Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.html

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/downloads_page/downloads_page.js ('K') | « chrome/browser/resources/settings/downloads_page/downloads_page.js ('k') | chrome/browser/resources/settings/privacy_page/privacy_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html

diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html

index 1e142918d847c221c9ab254716a7be8174b103e6..f9c04941c9b36f81254b7be59676fe719b4f44ef 100644

--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html

+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html

@@ -53,20 +53,25 @@

label="$i18n{linkDoctorPref}">

</settings-toggle-button>

</div>

- <div class="settings-box" hidden="[[!pageVisibility.searchPrediction]]">

- <settings-toggle-button class="start"

- pref="{{prefs.search.suggest_enabled}}"

- label="$i18n{searchSuggestPref}">

- </settings-toggle-button>

- </div>

- <div class="settings-box"

- hidden="[[!pageVisibility.networkPrediction]]">

- <settings-toggle-button class="start"

- pref="{{prefs.net.network_prediction_options}}"

- label="$i18n{networkPredictionEnabled}"

- numeric-unchecked-value="[[networkPredictionEnum_.NEVER]]">

- </settings-toggle-button>

- </div>

+ <template is="dom-if"

+ if="[[showPage_(pageVisibility.searchPrediction)]]">

+ <div class="settings-box">

+ <settings-toggle-button class="start"

+ pref="{{prefs.search.suggest_enabled}}"

+ label="$i18n{searchSuggestPref}">

+ </settings-toggle-button>

+ </div>

+ </template>

+ <template is="dom-if"

+ if="[[showPage_(pageVisibility.networkPrediction)]]">

+ <div class="settings-box">

+ <settings-toggle-button class="start"

+ pref="{{prefs.net.network_prediction_options}}"

+ label="$i18n{networkPredictionEnabled}"

+ numeric-unchecked-value="[[networkPredictionEnum_.NEVER]]">

+ </settings-toggle-button>

+ </div>

+ </template>

<settings-toggle-button class="start"

id="safeBrowsingExtendedReportingControl"