Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3273)

Unified Diff: chrome/test/data/webui/settings/appearance_page_test.js

Issue 2861443003: MD Settings: Fix subpage visibility and add appearance page tests (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/webui/settings/appearance_page_test.js
diff --git a/chrome/test/data/webui/settings/appearance_page_test.js b/chrome/test/data/webui/settings/appearance_page_test.js
index bc3cb043002f6b400580fede4c6ca353331a0797..9b5e8ad6fccb576ef652e2203632496a7a72ce02 100644
--- a/chrome/test/data/webui/settings/appearance_page_test.js
+++ b/chrome/test/data/webui/settings/appearance_page_test.js
@@ -115,6 +115,36 @@ function createAppearancePage() {
Polymer.dom.flush();
}
+suite('AppearancePageVisibility', function() {
+ setup(function() {
+ appearanceBrowserProxy = new TestAppearanceBrowserProxy();
+ settings.AppearanceBrowserProxyImpl.instance_ = appearanceBrowserProxy;
+ createAppearancePage();
+ });
+
+ teardown(function() { appearancePage.remove(); });
+
+ if (cr.isChromeOS) {
+ test('setWallpaper', function() {
+ assertTrue(!!appearancePage.$$('#setWallpaper'));
+ });
+ } else {
+ test('noSetWallpaper', function() {
+ assertTrue(!appearancePage.$$('#setWallpaper'));
+ });
+ }
+
+ test('setTheme', function() {
+ assertTrue(!!appearancePage.$$('#setTheme'));
+ });
+ test('homeButton', function() {
+ assertTrue(!!appearancePage.$$('#homeButton'));
+ });
+ test('bookmarksBar', function() {
+ assertTrue(!!appearancePage.$$('#bookmarksBar'));
+ });
+});
+
suite('AppearanceHandler', function() {
setup(function() {
appearanceBrowserProxy = new TestAppearanceBrowserProxy();
@@ -126,7 +156,7 @@ suite('AppearanceHandler', function() {
if (cr.isChromeOS) {
test('wallpaperManager', function() {
- var button = appearancePage.$.wallpaperButton;
+ var button = appearancePage.$$('#setWallpaper');
assertTrue(!!button);
MockInteractions.tap(button);
return appearanceBrowserProxy.whenCalled('openWallpaperManager');
@@ -134,7 +164,7 @@ suite('AppearanceHandler', function() {
} else {
test('noWallpaperManager', function() {
// The wallpaper button should not be present.
- var button = appearancePage.$.wallpaperButton;
+ var button = appearancePage.$$('#setWallpaper');
assertFalse(!!button);
});
}
@@ -215,7 +245,7 @@ suite('AppearanceHandler', function() {
test('default zoom handling', function() {
function getDefaultZoomText() {
- var zoomLevel = appearancePage.$.zoomLevel;
+ var zoomLevel = appearancePage.$$('#zoomLevel');
return zoomLevel.options[zoomLevel.selectedIndex].textContent.trim();
}
@@ -289,4 +319,4 @@ suite('HomeUrlInput', function() {
assertEquals(homeUrlInput.value, 'test');
});
});
-});
+});

Powered by Google App Engine
This is Rietveld 408576698