Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Issue 2861403003: [Merge M59] arc: Support UNINSTALL_SHORTCUT (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

[Merge M59] arc: Support UNINSTALL_SHORTCUT This adds handling UNINSTALL_SHORTCUT intent. BUG=717661 BUG=b/34749139 TEST=Manually with test app. Shortcuts added and removed properly. Extended unit_tests TBR=xiyuan@chromium.org,lhchavez@chromium.org,nasko@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2858703002 Cr-Commit-Position: refs/heads/master@{#469063} (cherry picked from commit cf0b40a80365c1c0de0d70e785ae91a26e547f74) Review-Url: https://codereview.chromium.org/2861403003 Cr-Commit-Position: refs/branch-heads/3071@{#459} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/2fced5a6012d10701e8a5e2d6901949fa035fa1a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 chunk +33 lines, -3 lines 0 comments Download
M components/arc/common/app.mojom View 3 chunks +7 lines, -2 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/arc/test/fake_app_instance.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (5 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861403003/1
3 years, 7 months ago (2017-05-08 19:39:03 UTC) #4
commit-bot: I haz the power
3 years, 7 months ago (2017-05-08 20:00:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2fced5a6012d10701e8a5e2d6901...

Powered by Google App Engine
This is Rietveld 408576698