Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Issue 2858703002: arc: Support UNINSTALL_SHORTCUT (Closed)

Created:
3 years, 7 months ago by khmel
Modified:
3 years, 7 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, tfarina, hidehiko+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, lhchavez+watch_chromium.org, victorhsieh+watch_chromium.org, darin (slow to review), Matt Giuca
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

arc: Support UNINSTALL_SHORTCUT This adds handling UNINSTALL_SHORTCUT intent. BUG=717661 BUG=b/34749139 TEST=Manually with test app. Shortcuts added and removed properly. Extended unit_tests Review-Url: https://codereview.chromium.org/2858703002 Cr-Commit-Position: refs/heads/master@{#469063} Committed: https://chromium.googlesource.com/chromium/src/+/cf0b40a80365c1c0de0d70e785ae91a26e547f74

Patch Set 1 #

Total comments: 7

Patch Set 2 : nit #

Total comments: 1

Patch Set 3 : typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -10 lines) Patch
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc View 1 1 chunk +31 lines, -0 lines 0 comments Download
M chrome/browser/ui/app_list/arc/arc_app_unittest.cc View 1 1 chunk +33 lines, -3 lines 0 comments Download
M components/arc/common/app.mojom View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M components/arc/test/fake_app_instance.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/arc/test/fake_app_instance.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
khmel
Hi Luis and Xiyuan, PTAL Thanks!
3 years, 7 months ago (2017-05-02 19:06:08 UTC) #2
xiyuan
lgtm
3 years, 7 months ago (2017-05-02 19:29:31 UTC) #3
Luis Héctor Chávez
https://codereview.chromium.org/2858703002/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right): https://codereview.chromium.org/2858703002/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc#newcode1097 chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:1097: std::string test_package_name; Maybe call these two |installed_package_name| and |installed_intent_uri|? ...
3 years, 7 months ago (2017-05-02 19:48:17 UTC) #4
khmel
Thanks for taking a look. PTAL updated version. https://codereview.chromium.org/2858703002/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc File chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc (right): https://codereview.chromium.org/2858703002/diff/1/chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc#newcode1097 chrome/browser/ui/app_list/arc/arc_app_list_prefs.cc:1097: std::string ...
3 years, 7 months ago (2017-05-02 20:09:44 UTC) #5
Luis Héctor Chávez
lgtm https://codereview.chromium.org/2858703002/diff/1/components/arc/common/app.mojom File components/arc/common/app.mojom (right): https://codereview.chromium.org/2858703002/diff/1/components/arc/common/app.mojom#newcode153 components/arc/common/app.mojom:153: // defined by it's |intent_uri| and |package_name|. On ...
3 years, 7 months ago (2017-05-02 20:23:49 UTC) #6
khmel
Thanks Luis, Adding nasko@ for components/arc/common/app.mojom PTAL
3 years, 7 months ago (2017-05-02 20:31:16 UTC) #8
nasko
components/arc/common/app.mojom LGTM https://codereview.chromium.org/2858703002/diff/20001/components/arc/common/app.mojom File components/arc/common/app.mojom (right): https://codereview.chromium.org/2858703002/diff/20001/components/arc/common/app.mojom#newcode153 components/arc/common/app.mojom:153: // defined by it's |intent_uri| and |package_name|. ...
3 years, 7 months ago (2017-05-03 18:34:45 UTC) #9
khmel
Thank you for review!
3 years, 7 months ago (2017-05-03 18:37:58 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2858703002/40001
3 years, 7 months ago (2017-05-03 18:39:09 UTC) #13
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 19:12:07 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/cf0b40a80365c1c0de0d70e785ae...

Powered by Google App Engine
This is Rietveld 408576698