Use NavigationBarDoneButton() matcher in EarlGrey tests.

Use NavigationBarDoneButton() matcher in EarlGrey tests.

Some tests were using the IDS label, when there is a matcher to make
it simpler. Also, cleanup some C-style calls wrapping EarlGrey methods.

BUG=693579
Review-Url: https://codereview.chromium.org/2861243002
Cr-Commit-Position: refs/heads/master@{#470214}
Committed: https://chromium.googlesource.com/chromium/src/+/85edb5c8cb4d700870cff49f11d133be7c64d10a

[baxley, 2017-05-08 22:38:36]

baxley@chromium.org changed reviewers:
+ eugenebut@chromium.org

[baxley, 2017-05-08 22:38:37]

https://codereview.chromium.org/2861243002/diff/1/ios/chrome/browser/ui/authe...
File
ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm
(right):

https://codereview.chromium.org/2861243002/diff/1/ios/chrome/browser/ui/authe...
ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm:459:
TapButtonWithLabelId(IDS_IOS_ACCOUNT_CONSISTENCY_SETUP_SKIP_BUTTON);
There's another bug to get rid of these methods, so I scoped this CL to only fix
up cases with navbardonebutton

[Eugene But (OOO till 7-30), 2017-05-08 22:43:16]

lgtm

[baxley, 2017-05-08 22:44:30]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2017-05-08 22:57:44]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 01:04:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:04:56]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[baxley, 2017-05-09 01:12:49]

The CQ bit was checked by baxley@chromium.org

[commit-bot: I haz the power, 2017-05-09 01:19:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:38:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494292369334090, "parent_rev":
"c50f8193152098b3d105545ffc78986e071a8623", "commit_rev":
"85edb5c8cb4d700870cff49f11d133be7c64d10a"}

[commit-bot: I haz the power, 2017-05-09 04:38:44]

Description was changed from

==========
Use NavigationBarDoneButton() matcher in EarlGrey tests.

Some tests were using the IDS label, when there is a matcher to make
it simpler. Also, cleanup some C-style calls wrapping EarlGrey methods.

BUG=693579
==========

to

==========
Use NavigationBarDoneButton() matcher in EarlGrey tests.

Some tests were using the IDS label, when there is a matcher to make
it simpler. Also, cleanup some C-style calls wrapping EarlGrey methods.

BUG=693579

Review-Url: https://codereview.chromium.org/2861243002
Cr-Commit-Position: refs/heads/master@{#470214}
Committed:
https://chromium.googlesource.com/chromium/src/+/85edb5c8cb4d700870cff49f11d1...
==========

[commit-bot: I haz the power, 2017-05-09 04:38:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85edb5c8cb4d700870cff49f11d1...