Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 2861243002: Use NavigationBarDoneButton() matcher in EarlGrey tests. (Closed)

Created:
3 years, 7 months ago by baxley
Modified:
3 years, 7 months ago
CC:
chromium-reviews, marq+watch_chromium.org, ios-reviews+chrome_chromium.org, noyau+watch_chromium.org, ios-reviews_chromium.org, pkl (ping after 24h if needed)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use NavigationBarDoneButton() matcher in EarlGrey tests. Some tests were using the IDS label, when there is a matcher to make it simpler. Also, cleanup some C-style calls wrapping EarlGrey methods. BUG=693579 Review-Url: https://codereview.chromium.org/2861243002 Cr-Commit-Position: refs/heads/master@{#470214} Committed: https://chromium.googlesource.com/chromium/src/+/85edb5c8cb4d700870cff49f11d133be7c64d10a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm View 12 chunks +24 lines, -18 lines 1 comment Download
M ios/chrome/browser/ui/history/history_ui_egtest.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/settings/accounts_collection_egtest.mm View 7 chunks +14 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
baxley
https://codereview.chromium.org/2861243002/diff/1/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm File ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm (right): https://codereview.chromium.org/2861243002/diff/1/ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm#newcode459 ios/chrome/browser/ui/authentication/signin_interaction_controller_egtest.mm:459: TapButtonWithLabelId(IDS_IOS_ACCOUNT_CONSISTENCY_SETUP_SKIP_BUTTON); There's another bug to get rid of these ...
3 years, 7 months ago (2017-05-08 22:38:37 UTC) #2
Eugene But (OOO till 7-30)
lgtm
3 years, 7 months ago (2017-05-08 22:43:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861243002/1
3 years, 7 months ago (2017-05-08 22:57:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/421248) win_clang on master.tryserver.chromium.win (JOB_FAILED, ...
3 years, 7 months ago (2017-05-09 01:04:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2861243002/1
3 years, 7 months ago (2017-05-09 01:19:45 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 04:38:47 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/85edb5c8cb4d700870cff49f11d1...

Powered by Google App Engine
This is Rietveld 408576698