MD WebUI: Reduce flickering of spinner in toolbar search field

MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the WebUI
toolbar search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861093002
Cr-Commit-Position: refs/heads/master@{#469935}
Committed: https://chromium.googlesource.com/chromium/src/+/7d1496a99b064d43adbee156731a2b895ced6d39

[tsergeant, 2017-05-05 01:44:57]

Description was changed from

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the toolbar
search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
==========

to

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the toolbar
search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-05 01:45:44]

Description was changed from

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the toolbar
search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the WebUI
toolbar search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-05-05 01:51:41]

tsergeant@chromium.org changed reviewers:
+ dbeam@chromium.org

[tsergeant, 2017-05-05 01:51:41]

PTAL, thanks!

[tsergeant, 2017-05-05 01:51:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 01:52:08]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 03:07:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 03:07:43]

Dry run: This issue passed the CQ dry run.

[Dan Beam, 2017-05-05 17:54:12]

lgtm

[tsergeant, 2017-05-08 00:12:04]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-08 00:12:11]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 01:27:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 01:27:31]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tsergeant, 2017-05-08 07:16:26]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-05-08 07:17:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 09:19:49]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494227786566600, "parent_rev":
"bc27f5ffc898c05ae0f3ca53cde799c4a01f3344", "commit_rev":
"7d1496a99b064d43adbee156731a2b895ced6d39"}

[commit-bot: I haz the power, 2017-05-08 09:19:59]

Description was changed from

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the WebUI
toolbar search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD WebUI: Reduce flickering of spinner in toolbar search field

In https://crrev.com/402922, the loading spinner inside the WebUI
toolbar search field was changed to gradually fade in and out, reducing
flickering when the spinner was only shown for a short amount of time.

However, https://crrev.com/416604 regressed this behavior by wrapping the
spinner in a dom-if, improving performance but preventing the fade
animation.

This CL combines both approaches, using a dom-if to lazily render the
spinner the first time it is used, but then using the fade animation to
show and hide the spinner thereafter.

BUG=718361
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2861093002
Cr-Commit-Position: refs/heads/master@{#469935}
Committed:
https://chromium.googlesource.com/chromium/src/+/7d1496a99b064d43adbee156731a...
==========

[commit-bot: I haz the power, 2017-05-08 09:20:00]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d1496a99b064d43adbee156731a...