ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js - Issue 2861093002: MD WebUI: Reduce flickering of spinner in toolbar search field

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

Issue 2861093002: MD WebUI: Reduce flickering of spinner in toolbar search field (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

diff --git a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

index 432c828d6b066bc932034e65f938e7956c98c6b6..0f4f1a5827573c939999de7eb3cbadaceb297b7c 100644

--- a/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

+++ b/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.js

@@ -94,7 +94,10 @@ Polymer({

* @private

computeIsSpinnerShown_: function() {

- return this.spinnerActive && this.showingSearch;

+ var showSpinner = this.spinnerActive && this.showingSearch;

+ if (showSpinner)

+ this.$.spinnerTemplate.if = true;

+ return showSpinner;

/** @private */

« no previous file with comments | « ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar_search_field.html ('k') | no next file » | no next file with comments »