Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2860883005: Revert of Disable unused skia icons for Android. (Closed)

Created:
3 years, 7 months ago by mthiesse
Modified:
3 years, 7 months ago
Reviewers:
sadrul, Evan Stade
CC:
chromium-reviews, feature-vr-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable unused skia icons for Android. (patchset #1 id:1 of https://codereview.chromium.org/2844513003/ ) Reason for revert: Patch is useless, reverting to reduce the complexity this adds. Original issue's description: > Disable unused skia icons for Android. > > We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. > > This saves ~12KB in debug MonochromePublic builds. > > BUG=715192 > > Review-Url: https://codereview.chromium.org/2844513003 > Cr-Commit-Position: refs/heads/master@{#467236} > Committed: https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71fd5873a3d18c0 TBR=sadrul@chromium.org,estade@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=715192 Review-Url: https://codereview.chromium.org/2860883005 Cr-Commit-Position: refs/heads/master@{#469673} Committed: https://chromium.googlesource.com/chromium/src/+/e85c66981e6d362d0f3d54ebbe84a6516ae081b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M ui/vector_icons/BUILD.gn View 1 chunk +25 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
mthiesse
Created Revert of Disable unused skia icons for Android.
3 years, 7 months ago (2017-05-05 15:15:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860883005/1
3 years, 7 months ago (2017-05-05 15:16:08 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-05 16:20:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e85c66981e6d362d0f3d54ebbe84...

Powered by Google App Engine
This is Rietveld 408576698