Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2844513003:
Disable unused skia icons for Android. (Closed)
DescriptionDisable unused skia icons for Android.
We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out.
This saves ~12KB in debug MonochromePublic builds.
BUG=715192
Review-Url: https://codereview.chromium.org/2844513003
Cr-Commit-Position: refs/heads/master@{#467236}
Committed: https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71fd5873a3d18c0
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
mthiesse@chromium.org changed reviewers: + sadrul@chromium.org
PTAL
Description was changed from ========== Disable unused skia icons for Android. We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. This saves ~12KB in debug MonochromePublic builds. BUG=715192 ========== to ========== Disable unused skia icons for Android. We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. This saves ~12KB in debug MonochromePublic builds. BUG=715192 ==========
sadrul@chromium.org changed reviewers: + estade@chromium.org
+estade@ mostly as FYI lgtm
The CQ bit was checked by mthiesse@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by mthiesse@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1493177242416440, "parent_rev":
"00a279559130cd2818c66eaf047a77d39158858a", "commit_rev":
"325ab947264549023c35565ca71fd5873a3d18c0"}
Message was sent while issue was closed.
Description was changed from ========== Disable unused skia icons for Android. We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. This saves ~12KB in debug MonochromePublic builds. BUG=715192 ========== to ========== Disable unused skia icons for Android. We only use a small subset of the vector icons for VR UI on Android, the rest can be compiled out. This saves ~12KB in debug MonochromePublic builds. BUG=715192 Review-Url: https://codereview.chromium.org/2844513003 Cr-Commit-Position: refs/heads/master@{#467236} Committed: https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71f...
Message was sent while issue was closed.
On 2017/04/26 05:03:31, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as > https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71f... what was the size change on a release build? Kinda surprised unused definitions wouldn't be compiled out.
Message was sent while issue was closed.
On 2017/04/26 15:14:53, Evan Stade wrote: > On 2017/04/26 05:03:31, commit-bot: I haz the power wrote: > > Committed patchset #1 (id:1) as > > > https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71f... > > what was the size change on a release build? Kinda surprised unused definitions > wouldn't be compiled out. Oh, they totally are being compiled out. Release build size in unchanged.
Message was sent while issue was closed.
On 2017/04/26 15:52:47, mthiesse wrote: > On 2017/04/26 15:14:53, Evan Stade wrote: > > On 2017/04/26 05:03:31, commit-bot: I haz the power wrote: > > > Committed patchset #1 (id:1) as > > > > > > https://chromium.googlesource.com/chromium/src/+/325ab947264549023c35565ca71f... > > > > what was the size change on a release build? Kinda surprised unused > definitions > > wouldn't be compiled out. > > Oh, they totally are being compiled out. Release build size in unchanged. I guess that makes this change kind of pointless.
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2860883005/ by mthiesse@chromium.org. The reason for reverting is: Patch is useless, reverting to reduce the complexity this adds.. |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
