Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1204)

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)
Patch Set: Revert comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/blink_ax_tree_source.cc
diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc
index 397c86e42ad0ce14085125a9a9e722163783a016..6c820b113de5ac48a6d330cd58886823aebbfcff 100644
--- a/content/renderer/accessibility/blink_ax_tree_source.cc
+++ b/content/renderer/accessibility/blink_ax_tree_source.cc
@@ -382,6 +382,7 @@ blink::WebAXObject BlinkAXTreeSource::GetNull() const {
void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
AXContentNodeData* dst) const {
dst->role = AXRoleFromBlink(src.Role());
+ dst->ClearBitfields();
tapted 2017/05/05 05:53:36 this one isn't needed I guess, because of the line
Patti Lor 2017/05/08 00:28:08 Reverted! (This will come back in a later patch th
dst->state = AXStateFromBlink(src);
dst->id = src.AxID();
@@ -629,7 +630,7 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.LiveRegionAtomic());
dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.LiveRegionBusy());
if (src.LiveRegionBusy())
- dst->state |= (1 << ui::AX_STATE_BUSY);
+ dst->AddState(ui::AX_STATE_BUSY);
if (!src.LiveRegionStatus().IsEmpty()) {
dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,
src.LiveRegionStatus().Utf8());

Powered by Google App Engine
This is Rietveld 408576698