A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

content/renderer/accessibility/blink_ax_tree_source.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/accessibility/blink_ax_tree_source.h"
 
 #include <stddef.h>
 
 #include <set>
 
@@ skipping 364 matching lines @@
   return node1.Equals(node2);
 }
 
 blink::WebAXObject BlinkAXTreeSource::GetNull() const {
   return blink::WebAXObject();
 }
 
 void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,
                                       AXContentNodeData* dst) const {
   dst->role = AXRoleFromBlink(src.Role());
+  dst->ClearBitfields();

[tapted, 2017/05/05 05:53:36]

this one isn't needed I guess, because of the line below?

[Patti Lor, 2017/05/08 00:28:08]

Reverted! (This will come back in a later patch though, since I'm planning to
add another bitfield.)

   dst->state = AXStateFromBlink(src);
   dst->id = src.AxID();
 
   TRACE_EVENT1("accessibility", "BlinkAXTreeSource::SerializeNode", "role",
                ui::ToString(dst->role));
 
   WebAXObject offset_container;
   WebFloatRect bounds_in_container;
   SkMatrix44 container_transform;
   src.GetRelativeBounds(offset_container, bounds_in_container,
@@ skipping 227 matching lines @@
       }
       dst->AddIntListAttribute(ui::AX_ATTR_MARKER_TYPES, marker_types);
       dst->AddIntListAttribute(ui::AX_ATTR_MARKER_STARTS, marker_starts);
       dst->AddIntListAttribute(ui::AX_ATTR_MARKER_ENDS, marker_ends);
     }
 
     if (src.IsInLiveRegion()) {
       dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.LiveRegionAtomic());
       dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.LiveRegionBusy());
       if (src.LiveRegionBusy())
-        dst->state |= (1 << ui::AX_STATE_BUSY);
+        dst->AddState(ui::AX_STATE_BUSY);
       if (!src.LiveRegionStatus().IsEmpty()) {
         dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,
                                 src.LiveRegionStatus().Utf8());
       }
       dst->AddStringAttribute(ui::AX_ATTR_LIVE_RELEVANT,
                               src.LiveRegionRelevant().Utf8());
       // If we are not at the root of an atomic live region.
       if (src.ContainerLiveRegionAtomic() &&
           !src.LiveRegionRoot().IsDetached() && !src.LiveRegionAtomic()) {
         dst->AddIntAttribute(ui::AX_ATTR_MEMBER_OF_ID,
@@ skipping 246 matching lines @@
     return WebAXObject();
 
   WebDocument document = render_frame_->GetWebFrame()->GetDocument();
   if (!document.IsNull())
     return document.AccessibilityObject();
 
   return WebAXObject();
 }
 
 }  // namespace content