A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

ui/accessibility/ax_node_data.h

Index: ui/accessibility/ax_node_data.h
diff --git a/ui/accessibility/ax_node_data.h b/ui/accessibility/ax_node_data.h
index f44024f79c157e04d18093e0e824e4026cdac0ef..bc3b16a8a0fa82243dcd76f1c07c480bd1e07091 100644
--- a/ui/accessibility/ax_node_data.h
+++ b/ui/accessibility/ax_node_data.h
@@ -106,12 +106,11 @@ struct AX_EXPORT AXNodeData {
   void SetValue(const std::string& value);
   void SetValue(const base::string16& value);
 
-  // Helper to check whether |state_flag| is set in the given |state|.
-  static bool IsFlagSet(uint32_t state, ui::AXState state_flag);
-
-  // Set or check bits in |state_|.
-  void AddStateFlag(ui::AXState state_flag);
-  bool HasStateFlag(ui::AXState state_flag) const;
+  // Clear all bits in preparation for use of AXNodeData.
+  void ClearBitfields();

[tapted, 2017/05/05 05:53:36]

I feel like this should be called InitState() or PrepareForState() or something
like that. It looks too strange for consumers to set some fields, then call
`ClearBitfields` before setting state-specific stuff -- it's too vague.

Perhaps the constructor should even take an `initial_state` argument (or it
should just set state to 0 and we lose some safety..). That's a decision for the
a11y owners though.

[Patti Lor, 2017/05/08 00:28:08]

Renamed to Init() for now, will link owners this comment.

+  // Set or check bits in |state|.
+  bool HasState(ui::AXState state_flag) const;
+  void AddState(ui::AXState state_flag);
 
   // Return a string representation of this data, for debugging.
   virtual std::string ToString() const;