ui/views/controls/tabbed_pane/tabbed_pane.cc - Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/tabbed_pane/tabbed_pane.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)

Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/tabbed_pane/tabbed_pane.cc

diff --git a/ui/views/controls/tabbed_pane/tabbed_pane.cc b/ui/views/controls/tabbed_pane/tabbed_pane.cc

index 98aa69deb8b67c7d0193c3393ebccba54bd187d1..ba9abe4d709946eb8906061956607ba8e11c3c11 100644

--- a/ui/views/controls/tabbed_pane/tabbed_pane.cc

+++ b/ui/views/controls/tabbed_pane/tabbed_pane.cc

@@ -228,9 +228,9 @@ void Tab::SetState(TabState tab_state) {

void Tab::GetAccessibleNodeData(ui::AXNodeData* data) {

data->role = ui::AX_ROLE_TAB;

data->SetName(title()->text());

- data->AddStateFlag(ui::AX_STATE_SELECTABLE);

+ data->AddState(ui::AX_STATE_SELECTABLE);

if (selected())

- data->AddStateFlag(ui::AX_STATE_SELECTED);

+ data->AddState(ui::AX_STATE_SELECTED);

}

bool Tab::HandleAccessibleAction(const ui::AXActionData& action_data) {