Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc

Issue 2860883003: A11y: Add/refactor methods for manipulating bitfields on AXNodeData. (Closed)
Patch Set: Delete AXNodeData::Init() and clear bitfields in AXNodeData() instead. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc
diff --git a/ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc b/ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc
index 37a006055be544ca872e1f75b275141a6147eb88..5e470b5727041fbc6c98b78be9d342870f03500a 100644
--- a/ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc
+++ b/ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc
@@ -159,18 +159,12 @@ TEST_F(TabbedPaneTest, SelectTabWithAccessibleAction) {
// Check the a11y information for each tab.
for (int i = 0; i < kNumTabs; ++i) {
ui::AXNodeData data;
-
- // AXViewObjWrapper::Serialize() and NativeViewAccessibilityBase::GetData()
- // are normally responsible for clearing the state from the default
- // AXNodeData constructor. Do the same here.
- data.state = 0;
-
GetTabAt(i)->GetAccessibleNodeData(&data);
SCOPED_TRACE(testing::Message() << "Tab at index: " << i);
EXPECT_EQ(ui::AX_ROLE_TAB, data.role);
EXPECT_EQ(DefaultTabTitle(), data.GetString16Attribute(ui::AX_ATTR_NAME));
- EXPECT_TRUE(data.HasStateFlag(ui::AX_STATE_SELECTABLE));
- EXPECT_EQ(i == 0, data.HasStateFlag(ui::AX_STATE_SELECTED));
+ EXPECT_TRUE(data.HasState(ui::AX_STATE_SELECTABLE));
+ EXPECT_EQ(i == 0, data.HasState(ui::AX_STATE_SELECTED));
}
ui::AXActionData action;

Powered by Google App Engine
This is Rietveld 408576698