IOThread::ConstructSystemRequestContext defrag.

IOThread::ConstructSystemRequestContext defrag.

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything, and create
everything inline with system URLRequestContext configuration.
3)  Switch the proxy service to using the system URLRequestContext.
4)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
5)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.

Hopefully the incremental approach will help to protect against regressions.

BUG=715695
Review-Url: https://codereview.chromium.org/2860813002
Cr-Commit-Position: refs/heads/master@{#469508}
Committed: https://chromium.googlesource.com/chromium/src/+/518c27b2f8b6f890ca41e560cede83555c90f1c9

[mmenke, 2017-05-03 19:42:53]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 19:43:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 19:56:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 19:56:07]

Dry run: Try jobs failed on following builders:
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[mmenke, 2017-05-03 20:04:29]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 20:04:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 20:59:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 20:59:11]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[mmenke, 2017-05-03 21:28:23]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 21:28:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 22:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 22:43:51]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-05-04 19:04:09]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[mmenke, 2017-05-04 19:04:17]

The CQ bit was unchecked by mmenke@chromium.org

[mmenke, 2017-05-04 19:06:58]

Description was changed from

==========
IOThread::ConstructSystemRequestContext defrag.

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything.
3)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
4)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.
5)  Switch to having URLRequestContextBuilder also set up the
  ProxyService (This isn't part of 4 for a reason...).

BUG=715695
==========

to

==========
IOThread::ConstructSystemRequestContext defrag.

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything, and create
everything inline with system URLRequestContext configuration.
3)  Switch the proxy service to using the system URLRequestContext.
4)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
5)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.

Hopefully the incremental approach will help to protect against regressions.

BUG=715695
==========

[mmenke, 2017-05-04 19:09:40]

mmenke@chromium.org changed reviewers:
+ asanka@chromium.org

[mmenke, 2017-05-04 19:09:40]

Asanka:  I was thinking I'd send my CLs to clean up URLRequestContext
construction your way.  Expect a lot of juggling things around, while
maintaining the same behavior.  This one is just to make future reviews easier. 
It's all cut/paste, other than the URLRequestContextBuilder changes.

[asanka, 2017-05-04 21:52:47]

lgtm

[asanka, 2017-05-04 21:53:15]

FYI: I'll be gone for two weeks starting next week.

[mmenke, 2017-05-04 22:14:08]

On 2017/05/04 21:53:15, asanka wrote:
> FYI: I'll be gone for two weeks starting next week.

Thanks!  Sorry, forgot about that.  I'll use Randy, then, since I suppose you'd
rather enjoy your vacation than do codereviews for some unexplicable reason.

[mmenke, 2017-05-04 22:18:10]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-04 22:18:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-04 22:19:21]

On 2017/05/04 22:14:08, mmenke wrote:
> On 2017/05/04 21:53:15, asanka wrote:
> > FYI: I'll be gone for two weeks starting next week.
> 
> Thanks!  Sorry, forgot about that.  I'll use Randy, then, since I suppose
you'd
> rather enjoy your vacation than do codereviews for some unexplicable reason.

And just a friendly reminder that you may want to update your name on
codereview.chromium.org to say that sooner rather than later.  :)

[commit-bot: I haz the power, 2017-05-04 23:15:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493936290801520,
"parent_rev": "01de9a363929c8e8d7ce99224ed3a77dce263b17", "commit_rev":
"518c27b2f8b6f890ca41e560cede83555c90f1c9"}

[commit-bot: I haz the power, 2017-05-04 23:16:28]

Description was changed from

==========
IOThread::ConstructSystemRequestContext defrag.

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything, and create
everything inline with system URLRequestContext configuration.
3)  Switch the proxy service to using the system URLRequestContext.
4)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
5)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.

Hopefully the incremental approach will help to protect against regressions.

BUG=715695
==========

to

==========
IOThread::ConstructSystemRequestContext defrag.

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything, and create
everything inline with system URLRequestContext configuration.
3)  Switch the proxy service to using the system URLRequestContext.
4)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
5)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.

Hopefully the incremental approach will help to protect against regressions.

BUG=715695

Review-Url: https://codereview.chromium.org/2860813002
Cr-Commit-Position: refs/heads/master@{#469508}
Committed:
https://chromium.googlesource.com/chromium/src/+/518c27b2f8b6f890ca41e560cede...
==========

[commit-bot: I haz the power, 2017-05-04 23:16:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/518c27b2f8b6f890ca41e560cede...

[asanka, 2017-05-05 02:46:43]

On 2017/05/04 22:19:21, mmenke wrote:
> On 2017/05/04 22:14:08, mmenke wrote:
> > On 2017/05/04 21:53:15, asanka wrote:
> > > FYI: I'll be gone for two weeks starting next week.
> > 
> > Thanks!  Sorry, forgot about that.  I'll use Randy, then, since I suppose
> you'd
> > rather enjoy your vacation than do codereviews for some unexplicable reason.
> 
> And just a friendly reminder that you may want to update your name on
> http://codereview.chromium.org to say that sooner rather than later.  :)

Done. Thanks!