Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext

Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext.

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG=715697
Review-Url: https://codereview.chromium.org/2841163002
Cr-Commit-Position: refs/heads/master@{#469044}
Committed: https://chromium.googlesource.com/chromium/src/+/0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393

[mmenke, 2017-04-26 19:27:31]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 19:28:20]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 19:45:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 19:45:52]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mmenke, 2017-04-26 19:49:04]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 19:50:09]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:05:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:05:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-04-26 20:07:10]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 20:08:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 20:34:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 20:34:01]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mmenke, 2017-04-26 21:00:08]

Description was changed from

==========
Remove Proxy URLRequestContext

BUG=
==========

to

==========
Remove Proxy URLRequestContext

BUG=
==========

[mmenke, 2017-04-26 21:06:46]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 21:07:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 21:27:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-26 21:27:11]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mmenke, 2017-04-28 20:38:17]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 20:39:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 20:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 20:45:23]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mmenke, 2017-05-01 19:03:17]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 19:04:28]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 19:08:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 19:08:32]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[mmenke, 2017-05-01 19:27:24]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 19:28:06]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-01 19:50:00]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 19:50:33]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 20:16:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:16:30]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[mmenke, 2017-05-01 20:42:15]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:43:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 20:53:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 20:53:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[mmenke, 2017-05-01 21:32:46]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[mmenke, 2017-05-01 21:32:54]

Patchset #10 (id:180001) has been deleted

[commit-bot: I haz the power, 2017-05-01 21:33:39]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-01 21:47:58]

Description was changed from

==========
Remove Proxy URLRequestContext

BUG=
==========

to

==========
Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext.

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG=715697
==========

[mmenke, 2017-05-01 21:53:15]

Patchset #7 (id:120001) has been deleted

[mmenke, 2017-05-01 21:53:31]

Patchset #5 (id:80001) has been deleted

[mmenke, 2017-05-01 21:53:39]

Patchset #4 (id:60001) has been deleted

[mmenke, 2017-05-01 21:53:48]

Patchset #4 (id:100001) has been deleted

[mmenke, 2017-05-01 21:53:58]

Patchset #2 (id:20001) has been deleted

[mmenke, 2017-05-01 21:54:07]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-05-01 22:41:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 22:41:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2017-05-02 18:26:05]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 18:26:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:28:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:28:38]

Dry run: This issue passed the CQ dry run.

[mmenke, 2017-05-02 20:10:25]

mmenke@chromium.org changed reviewers:
+ eroman@chromium.org

[mmenke, 2017-05-02 20:10:26]

I'll update the IOThread to do the same and remove the
ProxyScriptFetcherURLRequestContext in another CL.

Figure these CLs are complicated enough to be worth landing separately.

https://codereview.chromium.org/2841163002/diff/220001/chrome/browser/profile...
File chrome/browser/profiles/profile_impl_io_data.cc (right):

https://codereview.chromium.org/2841163002/diff/220001/chrome/browser/profile...
chrome/browser/profiles/profile_impl_io_data.cc:466:
content::URLRequestInterceptorScopedVector request_interceptors) const {
Splitting this method in two does seem a bit ugly, but I'd really like to get
rid of InitializeInternal entirely, and move most logic up to ProfileIOData
(Which I think will make it easier to switch to using URLRequestContextBuilder,
which will make it easier to make the network Service use
URLRequestContextBuilder in the exact same way).

https://codereview.chromium.org/2841163002/diff/220001/net/test/embedded_test...
File net/test/embedded_test_server/embedded_test_server.cc (right):

https://codereview.chromium.org/2841163002/diff/220001/net/test/embedded_test...
net/test/embedded_test_server/embedded_test_server.cc:81:
DCHECK(!io_thread_.get());
This makes sure that we haven't started the accept thread, though we may have
created the listen socket.

[mmenke, 2017-05-02 21:01:59]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 21:02:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-02 21:10:31]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 21:11:05]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mmenke, 2017-05-02 21:27:19]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 21:27:56]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-05-02 21:29:35]

lgtm

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
chrome/browser/profiles/profile_io_data.cc:1334: return
base::WrapUnique<net::NetworkDelegate>(
does this work?

return std::move(chrome_network_delegate);

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
File chrome/browser/profiles/profile_io_data.h (right):

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
chrome/browser/profiles/profile_io_data.h:452: // Does any necessary addition
configuration of the network delegate,
additional

[mmenke, 2017-05-02 21:33:59]

Thanks!  Sufficiently paranoid about this change that I'll wait until tomorrow
to land.

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
File chrome/browser/profiles/profile_io_data.cc (right):

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
chrome/browser/profiles/profile_io_data.cc:1334: return
base::WrapUnique<net::NetworkDelegate>(
On 2017/05/02 21:29:34, eroman wrote:
> does this work?
> 
> return std::move(chrome_network_delegate);

Fails to build on Android only.  :(

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
File chrome/browser/profiles/profile_io_data.h (right):

https://codereview.chromium.org/2841163002/diff/280001/chrome/browser/profile...
chrome/browser/profiles/profile_io_data.h:452: // Does any necessary addition
configuration of the network delegate,
On 2017/05/02 21:29:34, eroman wrote:
> additional

Done.

[mmenke, 2017-05-03 16:40:13]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2017-05-03 16:40:14]

The patchset sent to the CQ was uploaded after l-g-t-m from eroman@chromium.org
Link to the patchset: https://codereview.chromium.org/2841163002/#ps340001
(title: "Change test URL to not be the test (proxy) server's URL")

[commit-bot: I haz the power, 2017-05-03 16:40:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 16:40:57]

This CL has an open dependency (Issue 2845643003 Patch 260001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[mmenke, 2017-05-03 16:41:47]

On 2017/05/03 16:40:57, commit-bot: I haz the power wrote:
> This CL has an open dependency (Issue 2845643003 Patch 260001). Please resolve
> the dependency and try again.
> If you are sure that there is no real dependency, please use one of the
options
> listed in https://goo.gl/9Es4OR to land the CL.

Oops, thought I landed that.

[mmenke, 2017-05-03 17:10:28]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2017-05-03 17:11:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 18:40:13]

CQ is committing da patch.

Bot data: {"patchset_id": 340001, "attempt_start_ts": 1493831428681900,
"parent_rev": "40a227b78d6fed53d06420553275557179546502", "commit_rev":
"0a8ca0d1e3ac86cd1d0955fc66a43aaa1eaf7393"}

[commit-bot: I haz the power, 2017-05-03 18:40:45]

Description was changed from

==========
Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext.

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG=715697
==========

to

==========
Make ProfileIOData's ProxyService fetch PACs with the main URLRequestContext.

This is intended to make servicification a little simpler, since we won't
have to configure a secret global URLRequestContext used just to fetch PAC
scripts.

The system URLRequestContext will be updated in a similar manner in a
followup CL.

BUG=715697

Review-Url: https://codereview.chromium.org/2841163002
Cr-Commit-Position: refs/heads/master@{#469044}
Committed:
https://chromium.googlesource.com/chromium/src/+/0a8ca0d1e3ac86cd1d0955fc66a4...
==========

[commit-bot: I haz the power, 2017-05-03 18:40:46]

Committed patchset #11 (id:340001) as
https://chromium.googlesource.com/chromium/src/+/0a8ca0d1e3ac86cd1d0955fc66a4...

[mmenke, 2017-05-03 19:44:18]

On 2017/05/03 18:40:46, commit-bot: I haz the power wrote:
> Committed patchset #11 (id:340001) as
>
https://chromium.googlesource.com/chromium/src/+/0a8ca0d1e3ac86cd1d0955fc66a4...

(Eroman:  Just FYI, I decided to put off the IOThread part of this until I can
have the IOThread use URLRequestContextBuilder, as I think that order makes the
intermediate CLs simpler.)

[eroman, 2017-05-03 19:58:38]

acknowledged.

[mmenke, 2017-05-11 15:49:15]

A revert of this CL (patchset #11 id:340001) has been created in
https://codereview.chromium.org/2876463007/ by mmenke@chromium.org.

The reason for reverting is: This ran into a race with extension setup.  Have a
CL out to fix that, but reverting this in the meantime.  I'll plan to TBR the
reland, since this bug this tickled has no real relation to any code in this CL,
but is a pre-existing issue in other code that this tickled..