Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2860793003: Pass through tilt_x and tilt_y to blink (Closed)

Created:
3 years, 7 months ago by jkwang
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass through tilt_x and tilt_y to blink Tilt data was lost during event conversion. This patch fixes the code path. BUG=715289 TEST=Add log to ui event and compare it with javascript log of event.tiltX and event.tiltY Review-Url: https://codereview.chromium.org/2860793003 Cr-Commit-Position: refs/heads/master@{#472308} Committed: https://chromium.googlesource.com/chromium/src/+/0b0a0385c305c9dffc2cca15e3f58917ec245299

Patch Set 1 #

Patch Set 2 : Pass through tilt_x and tilt_y to blink #

Patch Set 3 : Pass through tilt_x and tilt_y to blink #

Total comments: 10

Patch Set 4 : Pass through tilt_x and tilt_y to blink #

Patch Set 5 : Pass through tilt_x and tilt_y to blink #

Patch Set 6 : Pass through tilt_x and tilt_y to blink #

Total comments: 1

Patch Set 7 : Pass through tilt_x and tilt_y to blink #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -106 lines) Patch
M content/browser/renderer_host/input/motion_event_web.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/motion_event_web.cc View 1 chunk +9 lines, -11 lines 0 comments Download
M content/browser/renderer_host/input/motion_event_web_unittest.cc View 1 2 3 2 chunks +44 lines, -40 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/input/web_input_event_builders_android.cc View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/renderer_host/input/web_input_event_util_unittest.cc View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 1 chunk +4 lines, -9 lines 0 comments Download
M ui/events/android/motion_event_android.h View 1 2 3 3 chunks +6 lines, -2 lines 0 comments Download
M ui/events/android/motion_event_android.cc View 1 2 3 4 5 chunks +43 lines, -8 lines 0 comments Download
M ui/events/android/motion_event_android_unittest.cc View 1 2 4 chunks +22 lines, -4 lines 0 comments Download
M ui/events/blink/blink_event_util.h View 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/blink/blink_event_util.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M ui/events/gesture_detection/motion_event.h View 1 2 3 4 5 6 2 chunks +12 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/motion_event_buffer_unittest.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M ui/events/gesture_detection/motion_event_generic.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/events/gesture_detection/motion_event_generic.cc View 3 chunks +13 lines, -8 lines 0 comments Download
M ui/events/gestures/motion_event_aura.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/test/motion_event_test_utils.cc View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 33 (19 generated)
use mustaq_at_chromium.org
Thanks for finding the crack in tilt_{x,y} plumbing. This is the right idea but the ...
3 years, 7 months ago (2017-05-08 19:27:35 UTC) #4
aelias_OOO_until_Jul13
SGTM to make motion_event.h strictly more expressive and map Android events to the new format ...
3 years, 7 months ago (2017-05-08 19:47:03 UTC) #7
aelias_OOO_until_Jul13
ui/events/android/motion_event_android.cc changes lgtm, thanks.
3 years, 7 months ago (2017-05-15 18:24:12 UTC) #8
use mustaq_at_chromium.org
Great, this is much cleaner and more efficient now. I have a couple of points ...
3 years, 7 months ago (2017-05-15 19:46:53 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860793003/60001
3 years, 7 months ago (2017-05-16 00:47:53 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/437696)
3 years, 7 months ago (2017-05-16 01:10:27 UTC) #15
jkwang
Could you take a look? sadrul? https://codereview.chromium.org/2860793003/diff/40001/content/browser/renderer_host/input/motion_event_web_unittest.cc File content/browser/renderer_host/input/motion_event_web_unittest.cc (right): https://codereview.chromium.org/2860793003/diff/40001/content/browser/renderer_host/input/motion_event_web_unittest.cc#newcode39 content/browser/renderer_host/input/motion_event_web_unittest.cc:39: for (float orientation ...
3 years, 7 months ago (2017-05-16 01:13:26 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860793003/80001
3 years, 7 months ago (2017-05-16 03:05:44 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/437840)
3 years, 7 months ago (2017-05-16 03:14:01 UTC) #22
sadrul
lgtm https://codereview.chromium.org/2860793003/diff/100001/ui/events/gesture_detection/motion_event.h File ui/events/gesture_detection/motion_event.h (right): https://codereview.chromium.org/2860793003/diff/100001/ui/events/gesture_detection/motion_event.h#newcode116 ui/events/gesture_detection/motion_event.h:116: // Stylus 3D orientation is returned in GetTiltX/Y. ...
3 years, 7 months ago (2017-05-16 19:21:57 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860793003/120001
3 years, 7 months ago (2017-05-16 20:04:09 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/455184)
3 years, 7 months ago (2017-05-16 21:53:35 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860793003/120001
3 years, 7 months ago (2017-05-16 23:51:51 UTC) #30
commit-bot: I haz the power
3 years, 7 months ago (2017-05-17 03:42:25 UTC) #33
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/0b0a0385c305c9dffc2cca15e3f5...

Powered by Google App Engine
This is Rietveld 408576698