Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2860783002: Plugins: Fix crash in PepperPluginInstanceImpl when render frame gone (Closed)

Created:
3 years, 7 months ago by tommycli
Modified:
3 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugins: Fix crash in PepperPluginInstanceImpl when render frame gone Adds a bunch of missing nullchecks. Not sure why crash frequency has increased recently. Perhaps changes in RenderFrameObserver lifecycle: https://codereview.chromium.org/2034153002 BUG=717886 Review-Url: https://codereview.chromium.org/2860783002 Cr-Commit-Position: refs/heads/master@{#469196} Committed: https://chromium.googlesource.com/chromium/src/+/6dd584326951d58d927149bec5d677b37cd917b1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M content/renderer/pepper/pepper_plugin_instance_impl.cc View 8 chunks +21 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tommycli
raymes: PTAL, feel free to check CQ if it looks good to you. I'll be ...
3 years, 7 months ago (2017-05-03 18:06:15 UTC) #4
raymes
lgtm thanks
3 years, 7 months ago (2017-05-03 23:16:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860783002/1
3 years, 7 months ago (2017-05-03 23:17:12 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 23:24:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6dd584326951d58d927149bec5d6...

Powered by Google App Engine
This is Rietveld 408576698