Remove ClosedWorld.allFunctions

Remove ClosedWorld.allFunctions

This move FunctionSet use inside ClosedWorldBase and enables
FunctionSetBuilder to be closed before the creation of the ClosedWorld object.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/b624614fd1b6bb66d8c2f6cebcae2f69e6bafe48

[Johnni Winther, 2017-05-03 13:54:51]

johnniwinther@google.com changed reviewers:
+ het@google.com, sigmund@google.com

[Johnni Winther, 2017-05-03 13:54:52]

het@ can you check the change in dump_info.dart ?

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/dump_i...
File pkg/compiler/lib/src/dump_info.dart (left):

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/dump_i...
pkg/compiler/lib/src/dump_info.dart:280: }
This seemed to be an attempt at only pulling the return type from live members.
The change will add the declared return type for all functions with a resolved
return type, but since we create 'inferredReturnType' and 'sideEffects' for all
function (the dummy values 'dynamic mask' and 'no side effects') for such
functions anyway, I consider this a benign change.

[Siggi Cherem (dart-lang), 2017-05-03 17:03:24]

lgtm

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:162: // compact than a hash set.
Once we get enough elements, we change
do you know if this is still the case, or does hashset now has this kind of
optimizations built in?

[Johnni Winther, 2017-05-08 09:10:53]

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/univer...
File pkg/compiler/lib/src/universe/function_set.dart (right):

https://codereview.chromium.org/2860733002/diff/1/pkg/compiler/lib/src/univer...
pkg/compiler/lib/src/universe/function_set.dart:162: // compact than a hash set.
Once we get enough elements, we change
On 2017/05/03 17:03:24, Siggi Cherem (dart-lang) wrote:
> do you know if this is still the case, or does hashset now has this kind of
> optimizations built in?
> 

I think this is built in now, I'll check at update later.

[Johnni Winther, 2017-05-08 09:16:07]

Description was changed from

==========
Remove ClosedWorld.allFunctions

This move FunctionSet use inside ClosedWorldBase and enables
FunctionSetBuilder to be closed before the creation of the ClosedWorld object.
==========

to

==========
Remove ClosedWorld.allFunctions

This move FunctionSet use inside ClosedWorldBase and enables
FunctionSetBuilder to be closed before the creation of the ClosedWorld object.

R=sigmund@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b624614fd1b6bb66d8c2f6cebcae2f69e6bafe48
==========

[Johnni Winther, 2017-05-08 09:16:09]

Committed patchset #1 (id:1) manually as
b624614fd1b6bb66d8c2f6cebcae2f69e6bafe48 (presubmit successful).