Remove ClosedWorld.allFunctions

pkg/compiler/lib/src/dump_info.dart

Index: pkg/compiler/lib/src/dump_info.dart
diff --git a/pkg/compiler/lib/src/dump_info.dart b/pkg/compiler/lib/src/dump_info.dart
index 67696cda0a740ba04ec207c83b086f9d48883995..4171c2614c338cdeb23c8bd9f4ea9f5393ae27ff 100644
--- a/pkg/compiler/lib/src/dump_info.dart
+++ b/pkg/compiler/lib/src/dump_info.dart
@@ -262,6 +262,7 @@ class ElementInfoCollector extends BaseElementVisitor<Info, dynamic> {
         isExternal: element.isPatched);
     String code = compiler.dumpInfoTask.codeOf(element);
 
+    String returnType = null;
     List<ParameterInfo> parameters = <ParameterInfo>[];
     if (element.hasFunctionSignature) {
       FunctionSignature signature = element.functionSignature;
@@ -269,15 +270,9 @@ class ElementInfoCollector extends BaseElementVisitor<Info, dynamic> {
         parameters.add(new ParameterInfo(parameter.name,
             '${_resultOfParameter(parameter).type}', '${parameter.node.type}'));
       });
-    }
-
-    String returnType = null;
-    // TODO(sigmund): why all these checks?
-    if (element.isInstanceMember &&
-        !element.isAbstract &&
-        closedWorld.allFunctions.contains(element as MemberElement)) {
       returnType = '${element.type.returnType}';
     }

[Johnni Winther, 2017/05/03 13:54:51]

This seemed to be an attempt at only pulling the return type from live members.
The change will add the declared return type for all functions with a resolved
return type, but since we create 'inferredReturnType' and 'sideEffects' for all
function (the dummy values 'dynamic mask' and 'no side effects') for such
functions anyway, I consider this a benign change.

+
     String inferredReturnType = '${_resultOfElement(element).returnType}';
     String sideEffects = '${closedWorld.getSideEffectsOfElement(element)}';
 
@@ -461,8 +456,8 @@ class DumpInfoTask extends CompilerTask implements InfoReporter {
         element,
         impact,
         new WorldImpactVisitorImpl(visitDynamicUse: (dynamicUse) {
-          selections.addAll(closedWorld.allFunctions
-              .filter(dynamicUse.selector, dynamicUse.mask)
+          selections.addAll(closedWorld
+              .locateMembers(dynamicUse.selector, dynamicUse.mask)
               .map((MemberElement e) => new Selection(e, dynamicUse.mask)));
         }, visitStaticUse: (staticUse) {
           selections.add(new Selection(staticUse.element, null));