Remove ClosedWorld.allFunctions

pkg/compiler/lib/src/dump_info.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dump_info;
 
 import 'dart:convert'
     show ChunkedConversionSink, JsonEncoder, StringConversionSink;
 
 import 'package:dart2js_info/info.dart';
@@ skipping 244 matching lines @@
       kind = FunctionInfo.CONSTRUCTOR_FUNCTION_KIND;
     }
 
     FunctionModifiers modifiers = new FunctionModifiers(
         isStatic: element.isStatic,
         isConst: element.isConst,
         isFactory: element.isFactoryConstructor,
         isExternal: element.isPatched);
     String code = compiler.dumpInfoTask.codeOf(element);
 
+    String returnType = null;
     List<ParameterInfo> parameters = <ParameterInfo>[];
     if (element.hasFunctionSignature) {
       FunctionSignature signature = element.functionSignature;
       signature.forEachParameter((parameter) {
         parameters.add(new ParameterInfo(parameter.name,
             '${_resultOfParameter(parameter).type}', '${parameter.node.type}'));
       });
+      returnType = '${element.type.returnType}';
     }
 
-    String returnType = null;
-    // TODO(sigmund): why all these checks?
-    if (element.isInstanceMember &&
-        !element.isAbstract &&
-        closedWorld.allFunctions.contains(element as MemberElement)) {
-      returnType = '${element.type.returnType}';
-    }

[Johnni Winther, 2017/05/03 13:54:51]

This seemed to be an attempt at only pulling the return type from live members.
The change will add the declared return type for all functions with a resolved
return type, but since we create 'inferredReturnType' and 'sideEffects' for all
function (the dummy values 'dynamic mask' and 'no side effects') for such
functions anyway, I consider this a benign change.

     String inferredReturnType = '${_resultOfElement(element).returnType}';
     String sideEffects = '${closedWorld.getSideEffectsOfElement(element)}';
 
     int inlinedCount = compiler.dumpInfoTask.inlineCount[element];
     if (inlinedCount == null) inlinedCount = 0;
 
     FunctionInfo info = new FunctionInfo(
         name: name,
         functionKind: kind,
         modifiers: modifiers,
@@ skipping 163 matching lines @@
    */
   Iterable<Selection> getRetaining(Element element, ClosedWorld closedWorld) {
     WorldImpact impact = impacts[element];
     if (impact == null) return const <Selection>[];
 
     var selections = <Selection>[];
     compiler.impactStrategy.visitImpact(
         element,
         impact,
         new WorldImpactVisitorImpl(visitDynamicUse: (dynamicUse) {
-          selections.addAll(closedWorld.allFunctions
-              .filter(dynamicUse.selector, dynamicUse.mask)
+          selections.addAll(closedWorld
+              .locateMembers(dynamicUse.selector, dynamicUse.mask)
               .map((MemberElement e) => new Selection(e, dynamicUse.mask)));
         }, visitStaticUse: (staticUse) {
           selections.add(new Selection(staticUse.element, null));
         }),
         IMPACT_USE);
     return selections;
   }
 
   // Returns true if we care about tracking the size of
   // this node.
@@ skipping 141 matching lines @@
 
     ChunkedConversionSink<Object> sink = encoder.startChunkedConversion(
         new StringConversionSink.fromStringSink(buffer));
     sink.add(new AllInfoJsonCodec().encode(result));
     compiler.reporter.reportInfo(NO_LOCATION_SPANNABLE, MessageKind.GENERIC, {
       'text': "View the dumped .info.json file at "
           "https://dart-lang.github.io/dump-info-visualizer"
     });
   }
 }