Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 2860703002: Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc. (Closed)

Created:
3 years, 7 months ago by fdoray
Modified:
3 years, 7 months ago
Reviewers:
danakj, sadrul
CC:
chromium-reviews, tfarina, dcheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use TaskScheduler instead of WorkerPool in x11_hotplug_event_handler.cc. The following traits are used: Priority: Inherited (default) The priority is inherited from the calling context (i.e. TaskTraits are initialized with the priority of the current task). Shutdown behavior: CONTINUE_ON_SHUTDOWN Tasks posted with this mode which have not started executing before shutdown is initiated will never run. Tasks with this mode running at shutdown will be ignored (the worker will not be joined). Note: Tasks that were previously posted to base::WorkerPool should use this shutdown behavior because this is how base::WorkerPool handles all its tasks. May Block: Tasks posted with MayBlock() may block. This includes but is not limited to tasks that wait on synchronous file I/O operations: read or write a file from disk, interact with a pipe or a socket, rename or delete a file, enumerate files in a directory, etc. This trait isn't required for the mere use of locks. BUG=659191 TBR=danakj@chromium.org Review-Url: https://codereview.chromium.org/2860703002 Cr-Commit-Position: refs/heads/master@{#471763} Committed: https://chromium.googlesource.com/chromium/src/+/4560bffcd8250247bbabe4f3f045ea7fa0d901ba

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : self-review #

Patch Set 5 : ScopedTaskEnvironment-in-CompositorTestSuite #

Patch Set 6 : rebase #

Patch Set 7 : rebase #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : rebase #

Patch Set 11 : Add ScopedTaskEnvironment in SoftwareOutputDeviceOzoneTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 2 3 4 5 6 7 8 9 10 3 chunks +5 lines, -6 lines 0 comments Download
M ui/base/dragdrop/os_exchange_data_provider_aurax11_unittest.cc View 1 3 chunks +6 lines, -3 lines 0 comments Download
M ui/compositor/test/test_suite.h View 1 2 3 4 2 chunks +4 lines, -2 lines 0 comments Download
M ui/compositor/test/test_suite.cc View 1 2 3 4 2 chunks +6 lines, -3 lines 0 comments Download
M ui/events/platform/x11/x11_hotplug_event_handler.cc View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 64 (53 generated)
fdoray
Please take a look.
3 years, 7 months ago (2017-05-09 21:46:01 UTC) #13
sadrul
lgtm
3 years, 7 months ago (2017-05-10 03:08:35 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860703002/60001
3 years, 7 months ago (2017-05-10 10:18:29 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/449921)
3 years, 7 months ago (2017-05-10 12:37:06 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860703002/80001
3 years, 7 months ago (2017-05-10 12:54:49 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/450069)
3 years, 7 months ago (2017-05-10 15:23:43 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860703002/200001
3 years, 7 months ago (2017-05-15 12:34:11 UTC) #54
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/436801)
3 years, 7 months ago (2017-05-15 12:45:23 UTC) #56
fdoray
TBR=danakj@chromium.org for adding a ScopedTaskEnvironment in content/browser/compositor/software_output_device_ozone_unittest.cc
3 years, 7 months ago (2017-05-15 13:39:18 UTC) #59
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860703002/200001
3 years, 7 months ago (2017-05-15 13:39:44 UTC) #61
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 15:03:54 UTC) #64
Message was sent while issue was closed.
Committed patchset #11 (id:200001) as
https://chromium.googlesource.com/chromium/src/+/4560bffcd8250247bbabe4f3f045...

Powered by Google App Engine
This is Rietveld 408576698