Change search selection action on the dialog

Change search selection action on the dialog

Adds a more generic call to the helper delegate and calls out to the
LocaleManager. Then LocaleManager does the actual search engine setting
and any other potential fallout of the search engine choice.

BUG=712836, 712833
Review-Url: https://codereview.chromium.org/2860643003
Cr-Commit-Position: refs/heads/master@{#469484}
Committed: https://chromium.googlesource.com/chromium/src/+/ff1c7739972e98c4fc3c06abf755bcab47691da0

[Yusuf, 2017-05-04 00:17:00]

yusufo@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[gone, 2017-05-04 17:11:16]

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java
(right):

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java:66:
public DefaultSearchEngineDialogHelper(@SearchEnginePromoType int dialogType,
You have the dialog type here; can you save it as a member variable of this
class and pass it into onUserSearchEngineChoice?

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java:119:
// TODO(dfalcantara): Prevent the dialog from appearing again.
Remove TODO.

[Yusuf, 2017-05-04 18:32:44]

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java
(right):

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java:66:
public DefaultSearchEngineDialogHelper(@SearchEnginePromoType int dialogType,
On 2017/05/04 17:11:15, slow (dfalcantara) wrote:
> You have the dialog type here; can you save it as a member variable of this
> class and pass it into onUserSearchEngineChoice?

Done.

https://codereview.chromium.org/2860643003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelper.java:119:
// TODO(dfalcantara): Prevent the dialog from appearing again.
On 2017/05/04 17:11:15, slow (dfalcantara) wrote:
> Remove TODO.

Done.

[gone, 2017-05-04 18:35:00]

lgtm

[Yusuf, 2017-05-04 19:21:10]

The CQ bit was checked by yusufo@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:21:43]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 19:51:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 19:51:59]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)

[Yusuf, 2017-05-04 21:00:46]

The CQ bit was checked by yusufo@chromium.org

[Yusuf, 2017-05-04 21:00:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2860643003/#ps40001
(title: "fixed tests")

[commit-bot: I haz the power, 2017-05-04 21:01:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 21:51:08]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493931646390550,
"parent_rev": "a038875de60252fb6bf6fb429e5feab5b1d0c3de", "commit_rev":
"ff1c7739972e98c4fc3c06abf755bcab47691da0"}

[commit-bot: I haz the power, 2017-05-04 21:51:24]

Description was changed from

==========
Change search selection action on the dialog

Adds a more generic call to the helper delegate and calls out to the
LocaleManager. Then LocaleManager does the actual search engine setting
and any other potential fallout of the search engine choice.

BUG=712836, 712833
==========

to

==========
Change search selection action on the dialog

Adds a more generic call to the helper delegate and calls out to the
LocaleManager. Then LocaleManager does the actual search engine setting
and any other potential fallout of the search engine choice.

BUG=712836, 712833

Review-Url: https://codereview.chromium.org/2860643003
Cr-Commit-Position: refs/heads/master@{#469484}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff1c7739972e98c4fc3c06abf755...
==========

[commit-bot: I haz the power, 2017-05-04 21:51:29]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ff1c7739972e98c4fc3c06abf755...