Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2974)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java

Issue 2860643003: Change search selection action on the dialog (Closed)
Patch Set: fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
index d9d1a8858489d585f71ddeb3c9b93f9af31e45a6..36793694ff152fb128bcbb1aec85fade035a49cc 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/locale/DefaultSearchEngineDialogHelperTest.java
@@ -34,17 +34,20 @@ import java.util.List;
*/
@RunWith(ChromeJUnit4ClassRunner.class)
public class DefaultSearchEngineDialogHelperTest {
- private class TestDelegate extends DefaultSearchEngineDialogHelper.TemplateUrlServiceDelegate {
+ private class TestDelegate extends DefaultSearchEngineDialogHelper.HelperDelegate {
+ public TestDelegate(int dialogType) {
+ super(dialogType);
+ }
+
public String chosenKeyword;
@Override
- protected List<TemplateUrl> getSearchEngines(int dialogType) {
- Assert.assertEquals(mDialogType, dialogType);
+ protected List<TemplateUrl> getSearchEngines() {
return mTemplateUrls;
}
@Override
- protected void setSearchEngine(String keyword) {
+ protected void onUserSeachEngineChoice(String keyword) {
chosenKeyword = keyword;
}
}
@@ -58,8 +61,8 @@ public class DefaultSearchEngineDialogHelperTest {
}
@Override
- protected TemplateUrlServiceDelegate createDelegate() {
- delegate = new TestDelegate();
+ protected HelperDelegate createDelegate(int dialogType) {
+ delegate = new TestDelegate(mDialogType);
return delegate;
}
}
@@ -80,7 +83,7 @@ public class DefaultSearchEngineDialogHelperTest {
private final List<TemplateUrl> mTemplateUrls = new ArrayList<>();
private Context mContext;
- private int mDialogType;
+ private @SearchEnginePromoType int mDialogType;
@Before
public void setUp() throws Exception {
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/locale/LocaleManager.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698