Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Issue 2860613002: Enable SharedArrayBuffer feature by default. (Closed)

Created:
3 years, 7 months ago by binji
Modified:
3 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : enable in RuntimeEnabledFeatures instead #

Patch Set 3 : remove virtual testsuites and updated test expectations #

Patch Set 4 : fix more test expectations, include https://codereview.chromium.org/2860303002 #

Patch Set 5 : merge HEAD #

Patch Set 6 : merge after Issue 2860303002 landed #

Patch Set 7 : merge, add dependency on 2860613002. #

Patch Set 8 : fix more expectations #

Patch Set 9 : merge HEAD #

Patch Set 10 : merge HEAD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -1038 lines) Patch
M content/public/common/content_features.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 1 2 3 4 5 6 7 8 9 7 chunks +7 lines, -17 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/LeakExpectations View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/MSANExpectations View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 1 2 3 4 5 6 7 8 9 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 1 2 15 chunks +0 lines, -21 lines 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 3 4 5 6 7 8 9 20 chunks +4 lines, -30 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 2 3 1 chunk +0 lines, -108 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/random-values-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/importKey-badParameters-expected.txt View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/worker-random-values-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-and-failure-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved-expected.txt View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring-expected.txt View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history-expected.txt View 1 2 3 4 5 6 1 chunk +0 lines, -23 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-success.sub-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-messagechannel-success-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-similar-but-cross-origin-success.sub-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success-expected.txt View 1 2 3 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-dedicatedworker-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-sharedworker-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-window-expected.txt View 1 2 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/beacon/beacon-basic-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/fontface-arraybuffer-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-atomics-wait-expected.txt View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-sharedarraybuffer-transfer-expected.txt View 1 2 3 4 5 6 1 chunk +70 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/send-arraybufferview-expected.txt View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 4 5 6 7 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/random-values-expected.txt View 1 2 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/subtle/importKey-badParameters-expected.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/worker-random-values-expected.txt View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/beacon/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/beacon/beacon-basic-expected.txt View 1 2 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/canvas/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/canvas/canvas-lost-gpu-context-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/css/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/css/fontface-arraybuffer-expected.txt View 1 2 1 chunk +0 lines, -18 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/dom/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/dom/geometry-interfaces-dom-matrix-expected.txt View 1 2 1 chunk +0 lines, -31 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/encoding/api/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/events/constructors/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/events/constructors/midi-message-event-constructor-expected.txt View 1 2 1 chunk +0 lines, -21 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/files/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/files/blob-constructor-expected.txt View 1 2 1 chunk +0 lines, -96 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/peerconnection/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt View 1 2 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-atomics-wait-expected.txt View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-onerror-09-expected.txt View 1 2 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-sharedarraybuffer-transfer-expected.txt View 1 2 3 1 chunk +0 lines, -73 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/media/media-source/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/push_messaging/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/websocket/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/websocket/send-arraybufferview-expected.txt View 1 2 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/sensor/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/storage/indexeddb/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt View 1 2 1 chunk +0 lines, -247 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webmidi/README.txt View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
D third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webmidi/send-messages-expected.txt View 1 2 1 chunk +0 lines, -48 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 1 2 3 4 5 6 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt View 1 2 2 chunks +9 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 5 6 7 8 9 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/send-messages-expected.txt View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 45 (34 generated)
binji
3 years, 7 months ago (2017-05-03 18:47:27 UTC) #4
jochen (gone - plz use gerrit)
can you instead flip the flag in RuntimeEnabledFeatures.json5?
3 years, 7 months ago (2017-05-05 14:25:15 UTC) #5
binji
On 2017/05/05 at 14:25:15, jochen wrote: > can you instead flip the flag in RuntimeEnabledFeatures.json5? ...
3 years, 7 months ago (2017-05-05 22:51:33 UTC) #10
jochen (gone - plz use gerrit)
does it make sense to also delete all virtual test suites that include SharedArrayBuffer now, ...
3 years, 7 months ago (2017-05-08 06:23:42 UTC) #11
binji
On 2017/05/08 at 06:23:42, jochen wrote: > does it make sense to also delete all ...
3 years, 7 months ago (2017-05-11 22:01:00 UTC) #29
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-12 17:38:44 UTC) #33
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860613002/160001
3 years, 7 months ago (2017-05-12 17:53:16 UTC) #35
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/435635)
3 years, 7 months ago (2017-05-12 18:47:23 UTC) #37
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2860613002/180001
3 years, 7 months ago (2017-05-12 19:32:22 UTC) #40
commit-bot: I haz the power
Committed patchset #10 (id:180001) as https://chromium.googlesource.com/chromium/src/+/e94f5343100836bcdc838dc4da4fd13d4c69a950
3 years, 7 months ago (2017-05-12 22:16:30 UTC) #43
Justin Donnelly
3 years, 7 months ago (2017-05-13 00:38:34 UTC) #45
Message was sent while issue was closed.
Reverted in https://codereview.chromium.org/2876293002.

Reason for revert: This change appears to break webkit_tests on the
WebKit Android (Nexus4) builder:

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Andr...

Powered by Google App Engine
This is Rietveld 408576698