Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2876293002: Revert "Enable SharedArrayBuffer feature by default." (Closed)

Created:
3 years, 7 months ago by Justin Donnelly
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, kenjibaheux+watch_chromium.org, tzik, johnme+watch_chromium.org, kinuko+worker_chromium.org, kinuko+watch, jsbell+serviceworker_chromium.org, toyoshim+midi_chromium.org, jam, darin-cc_chromium.org, blink-reviews, falken+watch_chromium.org, harkness+watch_chromium.org, blink-worker-reviews_chromium.org, blink-reviews-w3ctests_chromium.org, Peter Beverloo, nhiroki, feature-media-reviews_chromium.org, michaeln, shimazu+serviceworker_chromium.org, tfarina, serviceworker-reviews, shimazu+worker_chromium.org, kinuko+serviceworker, mac-reviews_chromium.org, horo+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Enable SharedArrayBuffer feature by default." This reverts commit e94f5343100836bcdc838dc4da4fd13d4c69a950. Reason for revert: This change appears to break webkit_tests on the WebKit Android (Nexus4) builder: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/64762 TBR=binji,jochen BUG= Review-Url: https://codereview.chromium.org/2876293002 . Cr-Commit-Position: refs/heads/master@{#471510} Committed: https://chromium.googlesource.com/chromium/src/+/7c38e38d74d60a27b733cdcbfc0c30f8bbedba60

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+364 lines, -197 lines) Patch
M content/public/common/content_features.cc View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG View 7 chunks +17 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/FlagExpectations/site-per-process View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/LeakExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/MSANExpectations View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/NeverFixTests View 3 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/SlowTests View 15 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/SmokeTests View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 20 chunks +30 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +108 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/crypto/random-values-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/subtle/importKey-badParameters-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/crypto/worker-random-values-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-and-failure-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/broadcastchannel-success-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/identity-not-preserved-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/no-transferring-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/serialization-via-history-expected.txt View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-domain-success.sub-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-messagechannel-success-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-serviceworker-failure.https-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-sharedworker-failure-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-similar-but-cross-origin-success.sub-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/infrastructure/safe-passing-of-structured-data/shared-array-buffers/window-simple-success-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-dedicatedworker-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-sharedworker-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-window-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/beacon/beacon-basic-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/fontface-arraybuffer-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-matrix-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/constructors/midi-message-event-constructor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/files/blob-constructor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-atomics-wait-expected.txt View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/workers/worker-sharedarraybuffer-transfer-expected.txt View 1 chunk +1 line, -70 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/websocket/send-arraybufferview-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/worklet/webexposed/global-interface-listing-paint-worklet-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/win/virtual/stable/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/random-values-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/subtle/importKey-badParameters-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/crypto/worker-random-values-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/beacon/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/beacon/beacon-basic-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/canvas/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/canvas/canvas-lost-gpu-context-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/css/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/css/fontface-arraybuffer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/dom/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/dom/geometry-interfaces-dom-matrix-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/encoding/api/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/events/constructors/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/events/constructors/midi-message-event-constructor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/files/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/files/blob-constructor-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/peerconnection/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/peerconnection/RTCPeerConnection-datachannel-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-atomics-wait-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-onerror-09-expected.txt View 1 chunk +16 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/fast/workers/worker-sharedarraybuffer-transfer-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/media/media-source/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/push_messaging/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/websocket/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/http/tests/websocket/send-arraybufferview-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/sensor/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/storage/indexeddb/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webaudio/dom-exceptions-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webmidi/README.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/virtual/sharedarraybuffer/webmidi/send-messages-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webaudio/dom-exceptions-expected.txt View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-compositor-worker-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-shared-worker-expected.txt View 2 chunks +0 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/webmidi/send-messages-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5 View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
Justin Donnelly
3 years, 7 months ago (2017-05-13 00:38:12 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
7c38e38d74d60a27b733cdcbfc0c30f8bbedba60 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698